Particles for badguys and Tux #2831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Video would be nice. |
|
Here is a video: |
- Star particles replaced with the generic particle sprite - these particles now only occur when an enemy is knocked off screen - melt particles adjusted - side particles amount now configurable, so some side particles (like ___shot enemies) release more particles, and enemies such as haywire, iceblock etc. hitting wall only release a few. - Leaf particles adjusted to spread out.
mrkubax10
added
type:feature
category:code
category:design
status:needs-review
|
IDK if I like this. The way the particles spawn is too generic. Could we have different effects per badguy? |
|
I like the idea but I would leave out collision particles because it may get laggy very quickly. |
|
Some suggestions after testing:
Side note, I'm gonna make some more particles sprites soon that you can use. I was planning for sprite used for: Granito, Flying Snowball, Stalactite and Mr. Tree/Stumpy. Just to let you know |
- Made dust particles gravity slower - Added fade out to particles that are on screen for a long time, like leaf - Brought back star particles for knocking enemy off screen only. Looks better than whatever was before.
|
I think particles should spawn from the center of the squished sprite and not from the center of the normal sprite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of what turns a meh game into a great game is having visual feedback whenever you engage in a special event. One way in which this can be incorporated into SuperTux is by adding some particles upon killing or squishing enemies. I added exactly that in this PR, alongside some particles for when significant impacts are made (like when an enemy hits a wall at a fast speed.)
Please test this PR, it is my first contribution in almost a year and I made it rather quickly, and surely there will be some design decisions to be made, and I will definitely be willing to work with that. But I think this is a good start.
The graphics added in this PR are created by RustyBox.
UPDATE: I am also updating Tux's particles here.