Mass-rename "node_nr" to "node_idx" #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no clue why it changed the whole ghoul.cpp file when I renamed stuff. |
MatusGuy
reviewed
Mar 29, 2024
"I have no clue why it changed the whole ghoul.cpp file when I renamed stuff." I do care, honestly. I just don't know why it changed that complete file. Maybe line endings? |
|
If you cared about git commit history you wouldn't just decide to rename things because yes. Also please fix ghoul.*pp |
mrkubax10
added
priority:low
type:patch
category:code
status:needs-review
tobbi
force-pushed
the
rename_node_no_to_idx
branch
from
aef2d6a
to
06df3eb
Compare
MatusGuy
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like using "nr", it seems to be non-programming terminology. The members are definitely "indices" and I think should be named that.