Bicycle platform improvements #2898
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MatusGuy
commented
Apr 7, 2024
MatusGuy
commented
- easier to place
- custom sprites
- unisolid
- follow paths
MatusGuy
added
status:in-progress
mrkubax10
reviewed
Apr 11, 2024
| @@ -55,8 +61,7 @@ BicyclePlatformChild::collision(GameObject& other, const CollisionHit& ) | |||
| const float gravity = Sector::get().get_gravity(); | |||
|
|
|||
| // Somehow the hit parameter does not get filled in, so to determine (hit.top == true) we do this: | |||
| { | ||
| child->remove_me(); | ||
| } | ||
| std::cout << m_angular_speed << std::endl; |
There was a problem hiding this comment.
Remove debug code (in other places too).
There was a problem hiding this comment.
This pull request is not ready for review
There was a problem hiding this comment.
You requested review from me.
There was a problem hiding this comment.
Oh, you're right, I did. It was an accident, sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.