Allow installation with Symfony 7 #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/upgrade-symfony-7
branch
3 times, most recently
from
01abfcf
to
a30c7b1
Compare
.github/workflows/build.yml
Outdated
| name: Remove analyse dependencies | ||
| run: | | ||
| composer remove vimeo/psalm --no-update | ||
| composer remove sylius-labs/coding-standard --no-update |
There was a problem hiding this comment.
This packages are not required to run tests but for linting on the latest dependencies it is required to upgrade it: SyliusLabs/CodingStandard#60
.github/workflows/build.yml
Outdated
| run: | | ||
| composer remove vimeo/psalm --no-update | ||
| composer remove sylius-labs/coding-standard --no-update | ||
| composer remove rector/rector --no-update |
There was a problem hiding this comment.
This packages are not required to run tests but for linting on the latest dependencies it is required to upgrade it: #132
.github/workflows/build.yml
Outdated
| run: composer update | ||
| name: Remove analyse dependencies | ||
| run: | | ||
| composer remove vimeo/psalm --no-update |
There was a problem hiding this comment.
This packages are not required to run tests but for linting on the latest dependencies it is required to upgrade it: #133
alexander-schranz
force-pushed
the
feature/upgrade-symfony-7
branch
from
d50bdde
to
ce41b47
Compare
This was referenced May 8, 2024
|
Hi @alexander-schranz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the usage of the Symfony Theme Bundle with Symfony 7. There are some blocking dev dependencies which I removed for testing Symfony 7, they are only required for the lint task so we can still make the Tests run on Symfony 7.
The changed methods should be no bc break as they are all part of final classes.