Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] remove potential LogicException from translation methods #168

Merged

Conversation

jrushlow
Copy link
Collaborator

The VerifyEmailSignatureComponents $generatedAt property is always an int - we no longer need to throw a LogicException if the value is null in:

  • getExpirationMessageKey()
  • getExpirationMessageData()
  • getExpiresAtIntervalInstance()

Consumers of this class do not need surround these methods with a try/catch(\LogicException) block.

@jrushlow jrushlow added the Feature New Feature label Mar 14, 2024
@jrushlow jrushlow added this to the 2.x - Pre-release milestone Mar 14, 2024
@jrushlow jrushlow merged commit 7ef1c50 into SymfonyCasts:2.x Mar 14, 2024
6 checks passed
@jrushlow jrushlow deleted the feature/2.x/remove-logic-exception branch March 14, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant