Fix issue #54 and Memory leak in Pascal Highlighters #86
Conversation
Sync with Synedit/Synedit
The created regular expressions were not freed.
pyscripter
changed the title
|
I do not see that the changes in SynEditPrint.pas do fix #54. The issue still occurs very often when I change the size of the preview window and just when I call the preview without changing anything. I have cherry-picked the memory leak fix commit b69a5ae and committed it after changing SynHighlighterPas.pas from UTF-8 without BOM back to ANSI. |
|
Regarding #54 . what I observed was that TextWidth/CharWidth in certain occasions returned values just above 1, in my case 1.02. In such cases the preview added a whole new space between the characters, causing the issue. Having a tolerance of 4% resolved the issue for me and the preview looked good in all cases. It would be useful if you could set a conditional break point and see what kind of values you get when the problem occurs. I suspect that with a slightly greater tolerance the issue should disappear. |
Fix print preview issue #54.