Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: HCAL: Applying the fix on pulse containment correction algorithm both for Run3 trigger primitives and Method 0 #1

Closed
wants to merge 3 commits into from

Conversation

TaeunKwon
Copy link
Owner

@TaeunKwon TaeunKwon commented Oct 19, 2021

PR description:

After the PR cms-sw#34572 and cms-sw#34805, the pulse containment correction(PCC) algorithm was updated to make the timePhase definition in HcalPulseContainment similar to SIM step for Run3 Trigger Primitives(TPs). This update was originally designed to make a better agreement between TP energy for the PFA1' scheme and MAHI energy, but recently we found that it also has affected TP energy for the PFA2 scheme(old TP algorithm), by reducing its energy scale by 3~4%. And because we haven't applied this update in the PCC algorithm for RecHits(Method 0), currently there exists a discrepancy between PFA2 and Method 0, which we don't want. Therefore, this PR applies the update on the PCC algorithm described in PR cms-sw#34572 also for method 0, by adding a shared configurable parameter switching on the PCC update both in TP and Method 0.

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

@TaeunKwon TaeunKwon changed the title Draft:applyFixPCC_bothInRHTP Draft: HCAL: Applying the fix on pulse containment correction algorithm both for Run3 trigger primitives and Method 0 Oct 19, 2021
@TaeunKwon TaeunKwon closed this Oct 21, 2021
@TaeunKwon TaeunKwon deleted the applyFixPCC_bothInRHTP branch October 21, 2021 10:26
TaeunKwon pushed a commit that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant