Draft: HCAL: Applying the fix on pulse containment correction algorithm both for Run3 trigger primitives and Method 0 #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
After the PR cms-sw#34572 and cms-sw#34805, the pulse containment correction(PCC) algorithm was updated to make the timePhase definition in HcalPulseContainment similar to SIM step for Run3 Trigger Primitives(TPs). This update was originally designed to make a better agreement between TP energy for the PFA1' scheme and MAHI energy, but recently we found that it also has affected TP energy for the PFA2 scheme(old TP algorithm), by reducing its energy scale by 3~4%. And because we haven't applied this update in the PCC algorithm for RecHits(Method 0), currently there exists a discrepancy between PFA2 and Method 0, which we don't want. Therefore, this PR applies the update on the PCC algorithm described in PR cms-sw#34572 also for method 0, by adding a shared configurable parameter switching on the PCC update both in TP and Method 0.
PR validation:
A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport.