Bug Fix: Calculate getTotalSize correctly when using multiple lanes #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y from the beginning
piecyk
reviewed
Feb 2, 2024
packages/virtual-core/src/index.ts
Outdated
| // If lanes is 1, use the last measurement's end, otherwise find the maximum end value among all measurements | ||
| end = this.options.lanes === 1 | ||
| ? (measurements[measurements.length - 1]?.end ?? 0) | ||
| : Math.max(...measurements.map((m) => m.end)); |
There was a problem hiding this comment.
I think we don't need to map over the whole measurements, this should work the same
Suggested change
| : Math.max(...measurements.map((m) => m.end)); | |
| : Math.max(...measurements.slice(-this.options.lanes).map((m) => m.end)); |
There was a problem hiding this comment.
Great optimization. Just pushed a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my application I have a waterfall style layout so the last item is not guaranteed to be the furthest away. I was having issues with the sizing not being correct, so after digging in I found the root cause and implemented a fix.
Example of my measurements array (look at the last 2 items and notice the 2nd to last has a greater end property):
I also included a small optimization for one lane. I am happy to tweak the logic in any way so just let me know. Happy to contribute!