Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is SavedGzipInBytes a decimal? #18

Closed
rosemaryehlers opened this issue Oct 24, 2016 · 2 comments
Closed

Why is SavedGzipInBytes a decimal? #18

rosemaryehlers opened this issue Oct 24, 2016 · 2 comments

Comments

@rosemaryehlers
Copy link

SavedGzipInBytes = OriginalGzipSize - MinifiedGzipSize;

But both OriginalGzipSize and MinifiedGzipSize are longs - having SavedGzipInBytes be a decimal seems unnecessary and confusing.

https://github.com/Taritsyn/WebMarkupMin/blob/master/src/WebMarkupMin.Core/MinificationStatistics.cs
Taritsyn added a commit that referenced this issue Oct 25, 2016
@Taritsyn
Fixed a error #18 “Why is SavedGzipInBytes a decimal?”
dd27632
@Taritsyn
Copy link
Owner

Hello, Rosemary!

Thanks for information.

@Taritsyn
Copy link
Owner

Hello, Rosemary!

In WebMarkupMin 2.2.2 fixed this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Taritsyn @rosemaryehlers