Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed gluster volume option fetching and parsing logic #718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GowthamShanmugam
Copy link
Contributor

bugzilla: 1685461
tendrl-bug-id: #717

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

bugzilla: 1685461
tendrl-bug-id: Tendrl#717

Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
@GowthamShanmugam GowthamShanmugam requested review from shtripat and a team as code owners March 6, 2019 12:14
@GowthamShanmugam
Copy link
Contributor Author

@shtripat please review

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@fff4e12). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #718   +/-   ##
=========================================
  Coverage          ?   39.18%           
=========================================
  Files             ?       42           
  Lines             ?     2080           
  Branches          ?      280           
=========================================
  Hits              ?      815           
  Misses            ?     1235           
  Partials          ?       30
Impacted Files Coverage Δ
tendrl/gluster_integration/sds_sync/__init__.py 14.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff4e12...7a8fbb3. Read the comment docs.

Copy link
Member

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants