Bufix: set last ID before asking for more data so we know if we get stuck #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjaeger
reviewed
Apr 9, 2024
| @@ -848,6 +848,7 @@ int thingset_bin_import_data_progressively(struct thingset_context *ts, uint8_t | |||
| ts->decoder->payload = ts->msg; | |||
| ts->decoder->elem_count = state.elem_count; | |||
| *consumed = successfully_parsed_bytes; | |||
| *last_id = id; | |||
There was a problem hiding this comment.
Are you sure this is correct? If we parse the ID successfully, but not the value, don't we want to parse the ID again in the next run?
There was a problem hiding this comment.
Yes, and we will do, assuming there is sufficient data. But as it is, because we don't update last_id, the if (id == *last_id) check never succeeds and we get stuck in a loop until the watchdog kills the thread.
martinjaeger
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.