Skip to content

Commit

Permalink
Pinned internal dependencies (#1247)
Browse files Browse the repository at this point in the history
ref https://app.incident.io/ghost/incidents/70
ref TryGhost/Ghost#18948

- `kg-default-nodes` is always required to be at the same version as used by our renderer, if we end up with mixed versions across packages due to yarn resolution then it can cause a situation where all card content is missing when rendering
- ensured all our internal dependencies are pinned to avoid potential mis-matches
  • Loading branch information
kevinansfield committed May 16, 2024
1 parent 8a9c2f5 commit 9b4b9a1
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion packages/kg-default-transforms/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@lexical/list": "0.13.1",
"@lexical/rich-text": "0.13.1",
"@lexical/utils": "0.13.1",
"@tryghost/kg-default-nodes": "^1.0.13",
"@tryghost/kg-default-nodes": "1.0.13",
"lexical": "0.13.1"
}
}
4 changes: 2 additions & 2 deletions packages/kg-html-to-lexical/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
"@lexical/link": "0.13.1",
"@lexical/list": "0.13.1",
"@lexical/rich-text": "0.13.1",
"@tryghost/kg-default-nodes": "^1.0.13",
"@tryghost/kg-default-transforms": "^1.0.14",
"@tryghost/kg-default-nodes": "1.0.13",
"@tryghost/kg-default-transforms": "1.0.14",
"jsdom": "^24.0.0",
"lexical": "0.13.1"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/kg-lexical-html-renderer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@lexical/link": "0.13.1",
"@lexical/list": "0.13.1",
"@lexical/rich-text": "0.13.1",
"@tryghost/kg-default-nodes": "^1.0.13",
"@tryghost/kg-default-nodes": "1.0.13",
"jsdom": "^24.0.0",
"lexical": "0.13.1",
"prettier": "^3.0.0"
Expand Down
14 changes: 7 additions & 7 deletions packages/koenig-lexical/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@
"@testing-library/react": "14.3.1",
"@tryghost/color-utils": "^0.2.0",
"@tryghost/helpers": "^1.1.81",
"@tryghost/kg-clean-basic-html": "^4.0.6",
"@tryghost/kg-converters": "^1.0.1",
"@tryghost/kg-default-nodes": "^1.0.13",
"@tryghost/kg-default-transforms": "^1.0.14",
"@tryghost/kg-markdown-html-renderer": "^7.0.3",
"@tryghost/kg-simplemde": "^3.0.1",
"@tryghost/kg-unsplash-selector": "^0.1.15",
"@tryghost/kg-clean-basic-html": "4.0.6",
"@tryghost/kg-converters": "1.0.1",
"@tryghost/kg-default-nodes": "1.0.13",
"@tryghost/kg-default-transforms": "1.0.14",
"@tryghost/kg-markdown-html-renderer": "7.0.3",
"@tryghost/kg-simplemde": "3.0.1",
"@tryghost/kg-unsplash-selector": "0.1.15",
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"@uiw/react-codemirror": "^4.19.6",
Expand Down

0 comments on commit 9b4b9a1

Please sign in to comment.