Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Fix some issues when linking against netcdf-C #435

Merged
merged 2 commits into from
Mar 14, 2024
Merged

CMake: Fix some issues when linking against netcdf-C #435

merged 2 commits into from
Mar 14, 2024

Conversation

ZedThree
Copy link
Contributor

If using the netcdf-C CMake build directory directly, then NETCDF_C_LIBRARY and NETCDF_C_INCLUDE_DIR won't be defined -- more consistent to link against netCDF::netcdf instead.

@WardF WardF self-assigned this Mar 14, 2024
@WardF WardF added this to the 4.6.2 milestone Mar 14, 2024
@WardF
Copy link
Member

WardF commented Mar 14, 2024

Thanks!

@WardF WardF merged commit 9c4cb9b into Unidata:main Mar 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WardF WardF WardF approved these changes

Assignees

@WardF WardF

Labels
area/build/cmake
Projects
None yet
Milestone
4.6.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZedThree @WardF