Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unchecked block for calculating fee #382

Open
wants to merge 1 commit into
base: 0.8
Choose a base branch
from

Conversation

danielNg25
Copy link

_getFeeGrowthInside in PositionValue.sol missing unchecked block results calculating incorrect fee for position

@jes16jupyter
Copy link

jes16jupyter commented Apr 17, 2024

I think this solves the issue I proposed in #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants