fix: add condition to show variants tab (#5775)

Adds a conditional check so we don't display this tab for strategies that don't support it.
Unleash · Jan 5, 2024 · 04814bf · 04814bf
1 parent de7f6e0
commit 04814bf
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/...tend/src/component/feature/FeatureStrategy/FeatureStrategyForm/NewFeatureStrategyForm.tsx b/...tend/src/component/feature/FeatureStrategy/FeatureStrategyForm/NewFeatureStrategyForm.tsx
@@ -339,6 +339,8 @@ export const NewFeatureStrategyForm = ({
         return constraintCount + segmentCount;
     };
 
+    const showVariants =
+        strategy.parameters && 'stickiness' in strategy.parameters;
     return (
         <>
             <StyledHeaderBox>
@@ -381,16 +383,18 @@ export const NewFeatureStrategyForm = ({
                         </Typography>
                     }
                 />
-                <Tab
-                    label={
-                        <Typography>
-                            Variants
-                            <StyledBadge>
-                                {strategy.variants?.length}
-                            </StyledBadge>
-                        </Typography>
-                    }
-                />
+                {showVariants && (
+                    <Tab
+                        label={
+                            <Typography>
+                                Variants
+                                <StyledBadge>
+                                    {strategy.variants?.length || 0}
+                                </StyledBadge>
+                            </Typography>
+                        }
+                    />
+                )}
             </StyledTabs>
             <StyledForm onSubmit={onSubmitWithValidation}>
                 <ConditionallyRender