refactor: remove client from frontend api (#6490)

There was extra call getClient().getAll() not needed and complicating readability.
Unleash · Mar 11, 2024 · 2997fae · 2997fae
1 parent 17ea8b3
commit 2997fae
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 11 deletions.
diff --git a/frontend/src/component/menu/Header/Header.tsx b/frontend/src/component/menu/Header/Header.tsx
@@ -39,7 +39,6 @@ import { Notifications } from 'component/common/Notifications/Notifications';
 import { useAdminRoutes } from 'component/admin/useAdminRoutes';
 import InviteLinkButton from './InviteLink/InviteLinkButton/InviteLinkButton';
 import { useUiFlag } from 'hooks/useUiFlag';
-import { INavigationMenuItem } from '../../../interfaces/route';
 import { Badge } from '../../common/Badge/Badge';
 
 const StyledHeader = styled(AppBar)(({ theme }) => ({

diff --git a/src/lib/proxy/client-feature-toggle-read-model-type.ts b/src/lib/proxy/client-feature-toggle-read-model-type.ts
@@ -1,5 +1,5 @@
 import { IFeatureToggleClient } from '../types';
 
 export interface IClientFeatureToggleReadModel {
-    getClient(): Promise<Record<string, Record<string, IFeatureToggleClient>>>;
+    getAll(): Promise<Record<string, Record<string, IFeatureToggleClient>>>;
 }
diff --git a/src/lib/proxy/client-feature-toggle-read-model.ts b/src/lib/proxy/client-feature-toggle-read-model.ts
@@ -25,7 +25,7 @@ export default class ClientFeatureToggleReadModel
             });
     }
 
-    private async getAll(): Promise<
+    public async getAll(): Promise<
         Record<string, Record<string, IFeatureToggleClient>>
     > {
         const stopTimer = this.timer(`getAll`);
@@ -180,10 +180,4 @@ export default class ClientFeatureToggleReadModel
             !feature.strategies?.find((s) => s?.id === row.strategy_id)
         );
     }
-
-    async getClient(): Promise<
-        Record<string, Record<string, IFeatureToggleClient>>
-    > {
-        return this.getAll();
-    }
 }
diff --git a/src/lib/proxy/fake-client-feature-toggle-read-model.ts b/src/lib/proxy/fake-client-feature-toggle-read-model.ts
@@ -11,7 +11,7 @@ export default class FakeClientFeatureToggleReadModel
         > = {},
     ) {}
 
-    getClient(): Promise<Record<string, Record<string, IFeatureToggleClient>>> {
+    getAll(): Promise<Record<string, Record<string, IFeatureToggleClient>>> {
         return Promise.resolve(this.value);
     }
 

diff --git a/src/lib/proxy/global-frontend-api-cache.ts b/src/lib/proxy/global-frontend-api-cache.ts
@@ -118,7 +118,7 @@ export class GlobalFrontendApiCache extends EventEmitter {
     }
 
     private async getAllFeatures(): Promise<FrontendApiFeatureCache> {
-        const features = await this.clientFeatureToggleReadModel.getClient();
+        const features = await this.clientFeatureToggleReadModel.getAll();
         return this.mapFeatures(features);
     }