Skip to content

Commit

Permalink
fix: Insights placement in drawer nav (#6846)
Browse files Browse the repository at this point in the history
Moves the Insights nav menu item down to match desktop ordering

Closes #
[1-2290](https://linear.app/unleash/issue/1-2290/mobile-menu-insights-pops-up-as-the-first-item)
<img width="951" alt="Screenshot 2024-04-12 at 13 12 25"
src="https://github.com/Unleash/unleash/assets/104830839/c4222912-2fb9-4d01-8c82-e3288738f52c">

---------

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
  • Loading branch information
andreas-unleash committed Apr 12, 2024
1 parent 945e086 commit 34e917f
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,6 @@ exports[`returns all baseRoutes 1`] = `
"title": "Unleash",
"type": "protected",
},
{
"component": [Function],
"enterprise": false,
"flag": "executiveDashboardUI",
"menu": {
"mobile": true,
},
"path": "/insights",
"title": "Insights",
"type": "protected",
},
{
"component": {
"$$typeof": Symbol(react.lazy),
Expand Down Expand Up @@ -151,6 +140,17 @@ exports[`returns all baseRoutes 1`] = `
"title": "Playground",
"type": "protected",
},
{
"component": [Function],
"enterprise": false,
"flag": "executiveDashboardUI",
"menu": {
"mobile": true,
},
"path": "/insights",
"title": "Insights",
"type": "protected",
},
{
"component": [Function],
"menu": {},
Expand Down
22 changes: 11 additions & 11 deletions frontend/src/component/menu/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,6 @@ export const routes: IRoute[] = [
isStandalone: true,
},

// Insights - previously "Executive dashboard"
{
path: '/insights',
title: 'Insights',
component: Insights,
type: 'protected',
menu: { mobile: true },
flag: 'executiveDashboardUI',
enterprise: false,
},

// Project
{
path: '/projects/create',
Expand Down Expand Up @@ -173,6 +162,17 @@ export const routes: IRoute[] = [
menu: { mobile: true },
},

// Insights
{
path: '/insights',
title: 'Insights',
component: Insights,
type: 'protected',
menu: { mobile: true },
flag: 'executiveDashboardUI',
enterprise: false,
},

// Applications
{
path: '/applications/:name/*',
Expand Down

0 comments on commit 34e917f

Please sign in to comment.