fix: move useEffect before renders (#5995)

Unleash · Jan 23, 2024 · 3fd735a · 3fd735a
1 parent 5305c86
commit 3fd735a
Showing 1 changed file with 18 additions and 18 deletions.
diff --git a/...tend/src/component/feature/FeatureStrategy/FeatureStrategyForm/NewFeatureStrategyForm.tsx b/...tend/src/component/feature/FeatureStrategy/FeatureStrategyForm/NewFeatureStrategyForm.tsx
@@ -232,6 +232,24 @@ export const NewFeatureStrategyForm = ({
         });
     });
 
+    const stickiness =
+        strategy?.parameters && 'stickiness' in strategy?.parameters
+            ? String(strategy.parameters.stickiness)
+            : 'default';
+
+    useEffect(() => {
+        setStrategy((prev) => ({
+            ...prev,
+            variants: (strategy.variants || []).map((variant) => ({
+                stickiness,
+                name: variant.name,
+                weight: variant.weight,
+                payload: variant.payload,
+                weightType: variant.weightType,
+            })),
+        }));
+    }, [stickiness, JSON.stringify(strategy.variants)]);
+
     const foundEnvironment = feature.environments.find(
         (environment) => environment.name === environmentId,
     );
@@ -354,24 +372,6 @@ export const NewFeatureStrategyForm = ({
     const showVariants =
         strategy.parameters && 'stickiness' in strategy.parameters;
 
-    const stickiness =
-        strategy?.parameters && 'stickiness' in strategy?.parameters
-            ? String(strategy.parameters.stickiness)
-            : 'default';
-
-    useEffect(() => {
-        setStrategy((prev) => ({
-            ...prev,
-            variants: (strategy.variants || []).map((variant) => ({
-                stickiness,
-                name: variant.name,
-                weight: variant.weight,
-                payload: variant.payload,
-                weightType: variant.weightType,
-            })),
-        }));
-    }, [stickiness, JSON.stringify(strategy.variants)]);
-
     return (
         <>
             <StyledHeaderBox>