chore: remove variant dependencies flag (#6896)

Unleash · Apr 25, 2024 · 44521c1 · 44521c1
1 parent af54e27
commit 44521c1
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 19 deletions.
diff --git a/frontend/src/component/feature/Dependencies/AddDependencyDialogue.test.tsx b/frontend/src/component/feature/Dependencies/AddDependencyDialogue.test.tsx
@@ -14,9 +14,6 @@ const setupApi = () => {
         versionInfo: {
             current: { oss: 'irrelevant', enterprise: 'some value' },
         },
-        flags: {
-            variantDependencies: true,
-        },
     });
 
     testServerRoute(

diff --git a/frontend/src/component/feature/Dependencies/AddDependencyDialogue.tsx b/frontend/src/component/feature/Dependencies/AddDependencyDialogue.tsx
@@ -4,7 +4,6 @@ import { Dialogue } from 'component/common/Dialogue/Dialogue';
 import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
 import { useChangeRequestsEnabled } from 'hooks/useChangeRequestsEnabled';
 import { DependenciesUpgradeAlert } from './DependenciesUpgradeAlert';
-import { useUiFlag } from 'hooks/useUiFlag';
 import type { IDependency } from '../../../interfaces/featureToggle';
 import { ParentVariantOptions } from './ParentVariantOptions';
 import { type ParentValue, REMOVE_DEPENDENCY_OPTION } from './constants';
@@ -64,12 +63,9 @@ export const AddDependencyDialogue = ({
     const { isChangeRequestConfiguredInAnyEnv } =
         useChangeRequestsEnabled(project);
 
-    const variantDependenciesEnabled = useUiFlag('variantDependencies');
-    const showStatus =
-        parent !== REMOVE_DEPENDENCY_OPTION.key && variantDependenciesEnabled;
+    const showStatus = parent !== REMOVE_DEPENDENCY_OPTION.key;
     const showVariants =
         parent !== REMOVE_DEPENDENCY_OPTION.key &&
-        variantDependenciesEnabled &&
         parentValue.status === 'enabled_with_variants';
 
     const selectStatus = (value: string) => {

diff --git a/...verviewSidePanel/FeatureOverviewSidePanelDetails/FeatureOverviewSidePanelDetails.test.tsx b/...verviewSidePanel/FeatureOverviewSidePanelDetails/FeatureOverviewSidePanelDetails.test.tsx
@@ -13,9 +13,6 @@ const setupApi = () => {
         versionInfo: {
             current: { oss: 'irrelevant', enterprise: 'some value' },
         },
-        flags: {
-            variantDependencies: true,
-        },
     });
     testServerRoute(server, '/api/admin/projects/default/features/feature', {});
     testServerRoute(

diff --git a/frontend/src/interfaces/uiConfig.ts b/frontend/src/interfaces/uiConfig.ts
@@ -78,7 +78,6 @@ export type UiFlags = {
     projectOverviewRefactor?: string;
     displayTrafficDataUsage?: boolean;
     disableShowContextFieldSelectionValues?: boolean;
-    variantDependencies?: boolean;
     projectOverviewRefactorFeedback?: boolean;
     featureLifecycle?: boolean;
     scimApi?: boolean;

diff --git a/src/lib/__snapshots__/create-config.test.ts.snap b/src/lib/__snapshots__/create-config.test.ts.snap
@@ -149,7 +149,6 @@ exports[`should create default config 1`] = `
       "strictSchemaValidation": false,
       "useMemoizedActiveTokens": false,
       "userAccessUIEnabled": false,
-      "variantDependencies": false,
     },
     "externalResolver": {
       "getVariant": [Function],

diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts
@@ -52,7 +52,6 @@ export type IFlagKey =
     | 'scimApi'
     | 'displayEdgeBanner'
     | 'projectOverviewRefactor'
-    | 'variantDependencies'
     | 'disableShowContextFieldSelectionValues'
     | 'bearerTokenMiddleware'
     | 'projectOverviewRefactorFeedback'
@@ -262,10 +261,6 @@ const flags: IFlags = {
             .UNLEASH_EXPERIMENTAL_DISABLE_SHOW_CONTEXT_FIELD_SELECTION_VALUES,
         false,
     ),
-    variantDependencies: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_VARIANT_DEPENDENCIES,
-        false,
-    ),
     bearerTokenMiddleware: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_BEARER_TOKEN_MIDDLEWARE,
         false,

diff --git a/src/server-dev.ts b/src/server-dev.ts
@@ -49,7 +49,6 @@ process.nextTick(async () => {
                         outdatedSdksBanner: true,
                         projectOverviewRefactor: true,
                         disableShowContextFieldSelectionValues: false,
-                        variantDependencies: true,
                         projectOverviewRefactorFeedback: true,
                         featureLifecycle: true,
                         projectListFilterMyProjects: true,