Skip to content

Commit

Permalink
fix: add migration patch
Browse files Browse the repository at this point in the history
This patch will fix issues introduced in Unleash v3.13.0. It only
affects users trying to upgrade from v3 to v4 and has been using
v3.13.0 which contained an incorrect migration file.
  • Loading branch information
ivarconr committed Feb 24, 2022
1 parent 6e09fa4 commit 48e09db
Show file tree
Hide file tree
Showing 5 changed files with 111 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/migrations/20210428103922-patch-role-table.js
@@ -0,0 +1,9 @@
'use strict';

exports.up = function (db, cb) {
db.runSql('ALTER TABLE roles ADD COLUMN IF NOT EXISTS project text', cb);
};

exports.down = function (db, cb) {
cb();
};
14 changes: 14 additions & 0 deletions src/migrations/20210428103924-patch-admin-role-name.js
@@ -0,0 +1,14 @@
'use strict';

exports.up = function (db, cb) {
db.runSql(
`
UPDATE roles set name='Admin' where name='Super User';
`,
cb,
);
};

exports.down = function (db, cb) {
cb();
};
27 changes: 27 additions & 0 deletions src/migrations/20210428103924-patch-admin_role.js
@@ -0,0 +1,27 @@
'use strict';

exports.up = function (db, cb) {
db.runSql(
`
DO $$
declare
begin
WITH admin AS (
SELECT * FROM roles WHERE name in ('Admin', 'Super User') LIMIT 1
)
INSERT into role_user(role_id, user_id)
VALUES
((select id from admin), (select id FROM users where username='admin' LIMIT 1));
EXCEPTION WHEN OTHERS THEN
raise notice 'Ignored';
end;
$$;`,
cb,
);
};

exports.down = function (db, cb) {
// We can't just remove roles for users as we don't know if there has been any manual additions.
cb();
};
53 changes: 53 additions & 0 deletions src/migrations/20210428103924-patch-role_permissions.js
@@ -0,0 +1,53 @@
'use strict';

exports.up = function (db, cb) {
db.runSql(
`
DO $$
declare
begin
WITH editor AS (
SELECT * FROM roles WHERE name in ('Editor', 'Regular') LIMIT 1
)
INSERT INTO role_permission(role_id, project, permission)
VALUES
((SELECT id from editor), '', 'CREATE_STRATEGY'),
((SELECT id from editor), '', 'UPDATE_STRATEGY'),
((SELECT id from editor), '', 'DELETE_STRATEGY'),
((SELECT id from editor), '', 'UPDATE_APPLICATION'),
((SELECT id from editor), '', 'CREATE_CONTEXT_FIELD'),
((SELECT id from editor), '', 'UPDATE_CONTEXT_FIELD'),
((SELECT id from editor), '', 'DELETE_CONTEXT_FIELD'),
((SELECT id from editor), '', 'CREATE_PROJECT'),
((SELECT id from editor), '', 'CREATE_ADDON'),
((SELECT id from editor), '', 'UPDATE_ADDON'),
((SELECT id from editor), '', 'DELETE_ADDON'),
((SELECT id from editor), 'default', 'UPDATE_PROJECT'),
((SELECT id from editor), 'default', 'DELETE_PROJECT'),
((SELECT id from editor), 'default', 'CREATE_FEATURE'),
((SELECT id from editor), 'default', 'UPDATE_FEATURE'),
((SELECT id from editor), 'default', 'DELETE_FEATURE');
-- Clean up duplicates
DELETE FROM role_permission p1
USING role_permission p2
WHERE p1.created_at < p2.created_at -- select the "older" ones
AND p1.project = p2.project -- list columns that define duplicates
AND p1.permission = p2.permission;
EXCEPTION WHEN OTHERS THEN
raise notice 'Ignored';
end;
$$;`,
cb,
);
};

exports.down = function (db, cb) {
cb();
};
@@ -0,0 +1,8 @@
exports.up = function (db, cb) {
db.runSql('ALTER TABLE roles DROP COLUMN IF EXISTS project', cb);
};

exports.down = function (db, cb) {
// We can't just remove roles for users as we don't know if there has been any manual additions.
db.runSql('ALTER TABLE roles ADD COLUMN IF NOT EXISTS project text', cb);
};

0 comments on commit 48e09db

Please sign in to comment.