fix: add missing environments field to uiConfigSchema (#1736)

* fix: add missing environment field to uiConfigSchema * refactor: avoid throwing when unleash-server is a dependency in dev mode
Unleash · Jun 21, 2022 · 7ee8892 · 7ee8892
1 parent 3239929
commit 7ee8892
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/src/lib/openapi/spec/ui-config-schema.test.ts b/src/lib/openapi/spec/ui-config-schema.test.ts
@@ -7,6 +7,7 @@ test('uiConfigSchema', () => {
         version: 'a',
         unleashUrl: 'a',
         baseUriPath: 'a',
+        environment: 'a',
         disablePasswordAuth: false,
         segmentValuesLimit: 0,
         strategySegmentsLimit: 0,

diff --git a/src/lib/openapi/spec/ui-config-schema.ts b/src/lib/openapi/spec/ui-config-schema.ts
@@ -24,6 +24,9 @@ export const uiConfigSchema = {
         version: {
             type: 'string',
         },
+        environment: {
+            type: 'string',
+        },
         unleashUrl: {
             type: 'string',
         },

diff --git a/src/lib/services/openapi-service.ts b/src/lib/services/openapi-service.ts
@@ -77,11 +77,7 @@ export class OpenApiService {
         const errors = validateSchema(schema, data);
 
         if (errors) {
-            if (process.env.NODE_ENV === 'development') {
-                throw new Error(JSON.stringify(errors, null, 2));
-            } else {
-                this.logger.warn('Invalid response:', errors);
-            }
+            this.logger.warn('Invalid response:', errors);
         }
 
         res.status(status).json(data);

diff --git a/src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap b/src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap
@@ -1052,6 +1052,9 @@ Object {
           "disablePasswordAuth": Object {
             "type": "boolean",
           },
+          "environment": Object {
+            "type": "string",
+          },
           "flags": Object {
             "additionalProperties": Object {
               "type": "boolean",