Skip to content

Commit

Permalink
fix: s/Never logged/Never/g in frontend (#2075)
Browse files Browse the repository at this point in the history
When a user has never been logged in "last login: never" reads better
than "last login: Never logged".
  • Loading branch information
gardleopard committed Sep 23, 2022
1 parent d7b2874 commit 87a9789
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion frontend/src/component/admin/groups/Group/Group.tsx
Expand Up @@ -115,7 +115,7 @@ export const Group: VFC = () => {
Header: 'Last login',
accessor: (row: IGroupUser) => row.seenAt || '',
Cell: ({ row: { original: user } }: any) => (
<TimeAgoCell value={user.seenAt} emptyText="Never logged" />
<TimeAgoCell value={user.seenAt} emptyText="Never" />
),
sortType: 'date',
maxWidth: 150,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/component/admin/users/UsersList/UsersList.tsx
Expand Up @@ -152,7 +152,7 @@ const UsersList = () => {
Header: 'Last login',
accessor: (row: any) => row.seenAt || '',
Cell: ({ row: { original: user } }: any) => (
<TimeAgoCell value={user.seenAt} emptyText="Never logged" />
<TimeAgoCell value={user.seenAt} emptyText="Never" />
),
disableGlobalFilter: true,
sortType: 'date',
Expand Down
Expand Up @@ -180,7 +180,7 @@ export const ProjectAccessTable: VFC = () => {
return userRow.addedAt || '';
},
Cell: ({ value }: { value: Date }) => (
<TimeAgoCell value={value} emptyText="Never logged" />
<TimeAgoCell value={value} emptyText="Never" />
),
sortType: 'date',
maxWidth: 150,
Expand All @@ -200,7 +200,7 @@ export const ProjectAccessTable: VFC = () => {
.reverse()[0];
},
Cell: ({ value }: { value: Date }) => (
<TimeAgoCell value={value} emptyText="Never logged" />
<TimeAgoCell value={value} emptyText="Never" />
),
sortType: 'date',
maxWidth: 150,
Expand Down
Expand Up @@ -89,7 +89,7 @@ const columns = [
Header: 'Last login',
accessor: (row: IGroupUser) => row.seenAt || '',
Cell: ({ row: { original: user } }: any) => (
<TimeAgoCell value={user.seenAt} emptyText="Never logged" />
<TimeAgoCell value={user.seenAt} emptyText="Never" />
),
sortType: 'date',
maxWidth: 150,
Expand Down

1 comment on commit 87a9789

@vercel
Copy link

@vercel vercel bot commented on 87a9789 Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.