Skip to content

Commit

Permalink
fix: hide project stats behind flag and backport to 4.21 (#3419)
Browse files Browse the repository at this point in the history
  • Loading branch information
sjaanus committed Mar 29, 2023
1 parent bc3196f commit b1c3470
Showing 1 changed file with 30 additions and 3 deletions.
33 changes: 30 additions & 3 deletions src/lib/services/project-service.ts
Expand Up @@ -18,7 +18,12 @@ import {
ProjectGroupUpdateRoleEvent,
FEATURE_ENVIRONMENT_ENABLED,
} from '../types/events';
import { IUnleashStores, IUnleashConfig, IAccountStore } from '../types';
import {
IUnleashStores,
IUnleashConfig,
IAccountStore,
IFlagResolver,
} from '../types';
import {
FeatureToggle,
IProject,
Expand Down Expand Up @@ -108,6 +113,8 @@ export default class ProjectService {

private projectStatsStore: IProjectStatsStore;

private flagResolver: IFlagResolver;

constructor(
{
projectStore,
Expand Down Expand Up @@ -150,6 +157,7 @@ export default class ProjectService {
this.accountStore = accountStore;
this.groupService = groupService;
this.projectStatsStore = projectStatsStore;
this.flagResolver = config.flagResolver;
this.logger = config.getLogger('services/project-service.js');
}

Expand Down Expand Up @@ -809,9 +817,8 @@ export default class ProjectService {
project: projectId,
userId,
}),
this.projectStatsStore.getProjectStats(projectId),
this.getProjectStats(projectId),
]);

return {
stats: projectStats,
name: project.name,
Expand All @@ -825,4 +832,24 @@ export default class ProjectService {
version: 1,
};
}

getProjectStats = async (projectId: string): Promise<IProjectStats> => {
if (this.flagResolver.isEnabled('projectStatusApi')) {
const projectStats = await this.projectStatsStore.getProjectStats(
projectId,
);
return projectStats;
}
return {
archivedCurrentWindow: 0,
archivedPastWindow: 0,
avgTimeToProdCurrentWindow: 0,
avgTimeToProdPastWindow: 0,
createdCurrentWindow: 0,
createdPastWindow: 0,
projectActivityCurrentWindow: 0,
projectActivityPastWindow: 0,
projectMembersAddedCurrentWindow: 0,
};
};
}

0 comments on commit b1c3470

Please sign in to comment.