Skip to content

Commit

Permalink
chore: Improve UI Config type (#4959)
Browse files Browse the repository at this point in the history
Fix link types
  • Loading branch information
gastonfournier committed Oct 6, 2023
1 parent 8b0cf8b commit c3e8d74
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/lib/db/transaction.ts
Expand Up @@ -27,7 +27,7 @@ export type WithTransactional<S> = S & {
};

/**
* @deprecated this is a temporal solution to deal with transactions at the store level.
* @deprecated this is a temporary solution to deal with transactions at the store level.
* Ideally, we should handle transactions at the service level (each service method should be transactional).
* The controller should define the transactional scope as follows:
* https://github.com/Unleash/unleash/blob/cb034976b93abc799df774858d716a49f645d669/src/lib/features/export-import-toggles/export-import-controller.ts#L206-L208
Expand Down
14 changes: 6 additions & 8 deletions src/lib/types/option.ts
Expand Up @@ -148,14 +148,12 @@ export interface IUIConfig {
environment?: string;
slogan?: string;
name?: string;
links?: [
{
value: string;
icon?: string;
href: string;
title: string;
},
];
links?: {
value: string;
icon?: string;
href: string;
title: string;
}[];
flags?: IFlags;
}

Expand Down

0 comments on commit c3e8d74

Please sign in to comment.