Skip to content

Commit

Permalink
fix: scim id was not unique (#6450)
Browse files Browse the repository at this point in the history
This PR drops the previous PRs scim_id idx and replaces it with an
actual UNIQUE index
  • Loading branch information
Christopher Kolstad committed Mar 12, 2024
1 parent 74df643 commit ca329da
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/migrations/20240305131822-add-scim-id-column-to-user.js
@@ -1,13 +1,13 @@
exports.up = function(db, cb) {
db.runSql(`
ALTER TABLE users ADD COLUMN scim_id TEXT;
CREATE INDEX users_scim_id_uniq_idx ON users (scim_id) WHERE scim_id IS NOT NULL;
CREATE INDEX IF NOT EXISTS users_scim_id_uniq_idx ON users (scim_id) WHERE scim_id IS NOT NULL;
`, cb);
};

exports.down = function(db, cb) {
db.runSql(`
DROP INDEX users_scim_id_uniq_idx;
DROP INDEX IF EXISTS users_scim_id_uniq_idx;
ALTER TABLE users DROP COLUMN scim_id;
`, cb);
};
8 changes: 8 additions & 0 deletions src/migrations/20240306145609-make-scim-id-idx-unique.js
@@ -0,0 +1,8 @@
exports.up = function(db, cb) {
db.runSql(`DROP INDEX IF EXISTS users_scim_id_uniq_idx;
CREATE UNIQUE INDEX users_scim_id_unique_idx ON users(scim_id) WHERE scim_id IS NOT NULL`, cb);
};

exports.down = function(db, cb) {
db.runSql(`DROP INDEX IF EXISTS users_scim_id_unique_idx;`, cb);
};

0 comments on commit ca329da

Please sign in to comment.