fix: return 400 on invalid JSON instead of 404 (#1897)

Unleash · Aug 8, 2022 · df910cc · df910cc
1 parent d4b9ca4
commit df910cc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/lib/services/openapi-service.ts b/src/lib/services/openapi-service.ts
@@ -59,7 +59,7 @@ export class OpenApiService {
                     validation: err.validationErrors,
                 });
             } else {
-                next();
+                next(err);
             }
         });
     }

diff --git a/src/test/e2e/api/admin/feature.e2e.test.ts b/src/test/e2e/api/admin/feature.e2e.test.ts
@@ -340,6 +340,15 @@ test('require new feature toggle to have a name', async () => {
         .expect(400);
 });
 
+test('should return 400 on invalid JSON data', async () => {
+    expect.assertions(0);
+    return app.request
+        .post('/api/admin/features')
+        .send(`{ invalid-json }`)
+        .set('Content-Type', 'application/json')
+        .expect(400);
+});
+
 test('can not change status of feature toggle that does not exist', async () => {
     expect.assertions(0);
     return app.request