Skip to content

Commit

Permalink
fix: missing node engine upgrade to 18 (#3552)
Browse files Browse the repository at this point in the history
## About the changes
Updates frontend engine minimum version to node 18 and also improves
some messages in the release GHA task
  • Loading branch information
gastonfournier committed Apr 18, 2023
1 parent af67c0c commit e6f3b30
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/release.yaml
Expand Up @@ -14,16 +14,21 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Publish to npm
- name: Setup to npm
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'
- run: |
- name: Build
run: |
yarn install --frozen-lockfile
yarn --cwd ./frontend install --frozen-lockfile
- run: |
ls -l ./frontend
ls -l ./frontend/build
npm publish --dry-run
- name: Publish to npm
run: |
LATEST=$(npm show unleash-server version)
TAG=$(node scripts/npm-tag.js $LATEST)
npm publish --tag ${TAG:-latest}
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
Expand Up @@ -7,7 +7,7 @@
"build/"
],
"engines": {
"node": ">=14"
"node": ">=18"
},
"scripts": {
"build": "vite build",
Expand Down
4 changes: 3 additions & 1 deletion package.json
Expand Up @@ -11,7 +11,9 @@
"files": [
"dist",
"docs",
"frontend/build"
"frontend/build",
"frontend/index.js",
"frontend/package.json"
],
"repository": {
"type": "git",
Expand Down

0 comments on commit e6f3b30

Please sign in to comment.