New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional Holomaps & a wheelchair to Nerva #1434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is out of date and regresses previous map changes, notably ones made in #1418 . You'll need to rebase onto baymerge-testing
…tation into holomap_passux
I've rebased onto baymerge, I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The map in the hanger is the wrong direction and in the middle of the floor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the idea, however, I have a couple of issues/points.
- Some of the maps' overlays appear to spawn on the wrong tile, and kinda just float in mid-air. This looks odd and would ideally be fixed
- The placement sometimes feels a little random? ie the one outside the teleporter and inside cargo. Is there a way to make them a little more uniform? ie outside stairs, evenly spaced in public hallways in the same tough position on each floor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Holomap outside the elevator is literally like 5 steps from another one, do we need them this close?
- Holomap in the dorms overlaps the camera and looks odd
- Holomap in the starboard observatory overlaps a light and looks odd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a pass tonight and make some changes, need to fix the weird dir issues as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, they definitely don't need to be that close, especially because they do have a slight performance impact while in use iirc
This pull request has not been updated in 30 days, and will close in 7 days from now if no updates are made. Please address any outstanding review items and ensure your pull request is finished. If you have already done this and you are auto-staled anyway, ask a maintainer for an update. |
This pull request was closed because it has been stalled for 7 days with no activity. |
This adds additional Holomaps all around the Nerva, usually near key and memorable areas, or specific hallways.
The intent is to make it easier for new players to look around the map aside from viewing that one pinned PNG
Locations:
Deck 1:
Bottom of Trajan Hangar
Deck 2:
Cryo Storage
Bar
Near Security Lobby
Holodeck
Deck 3:
Near Deck 3 Stairway Elevator.
Dormitory
Observatory
Near Teleporter Outside.
Deck 4:
Top Docking Port.
This also adds a singular wheelchair in the Medical Storage Bay.
TODO: