Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashlight Subtypes (Flares, Glowsticks, Lanterns, Penlights, Flashdarks, Lamps) now have action buttons. #1447

Open
wants to merge 2 commits into
base: baymerge-testing
Choose a base branch
from

Conversation

Yantarii
Copy link
Contributor

image

Emergency Flares and Glowsticks now have action buttons to ignite/snap them.
Pressing them again will just inform the user in chat that it's already ignited/in use.

@Yantarii
Copy link
Contributor Author

Yantarii commented Apr 22, 2024

Lanterns, Penlights, Flashdarks and Lamps now have their own specific action button text.
Should be good to go.

@Yantarii Yantarii changed the title Flares & Glowsticks now have Action Button UI Flashlight Subtypes (Flares, Glowsticks, Lanterns, Penlights, Flashdarks, Lamps) now have action buttons. Apr 22, 2024
@CPU-Blanc
Copy link
Contributor

I don't really see why the glowstick & flares would need a dedicated action button, given they are single use?

@ErrorsWindows
Copy link
Contributor

you squeeze the pocket that has the glowstick in it with your hand to crackle it instead of having to take it out

@Yantarii
Copy link
Contributor Author

Going to adjust flares and glowsticks to have a button only when unlit to activate them.

I would prefer to keep subtypes of objects/devices consistent UI wise, I think single-use button prompts aren't going to cause much of an issue screen-estate wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants