1.20 adding charms in charm slots #4447
Conversation
Add hand/charm and moved ``divaCharm`` and ``goddessCharm`` to section (hopefuly I did this right)
|
also needs backport to 1.19.2 as a reminder :D |
|
You need to run |
|
Also, you're missing this change from the other PR. Is that intentional? https://github.com/VazkiiMods/Botania/pull/4443/files#diff-478bd022a79d7cb1ddd31a5f0a03f5d5ca5446fafcfe9f4abf6fc5b7e06f20f8 That part should be done manually because it's not in the |
- runFabricDatagen ran wtih previous commit made above (NOTE: Error message generated upon run: `com.mojang.authlib.exceptions.MinecraftClientHttpException: Status: 401` - Added `"hand/charm"` slot; hopefully this dosen't create a second slot with other mods that add this slot in. - Cached Data changes from datagen run (unsure if this is needed but including just in case) Reviews needed before approval
|
Please review this before approving it; I'll not lie when I say I only have a fundamental understanding of how the datapack aspect of this works. I will admit I do not know how to code with Java but I feel that my understanding of Minecraft's datapack system that is integrated with mods is solid enough for me to contribute in those areas. Thanks for the instructions on the datagen task. I would also work in Trinket Case compact with trinkets but that is outside of my range of possibility |
|
The code looks good to me. Did you run the game and see if it worked ingame? If so I can land this. |
|
game boots but its not creatin the charm slot for some reason |
|
Ok I see what needs to be done now I'll need to add a custom slot in the same place entities are located;as in add a new file lel I'll finish that up tomorrow when I have the chance |
|
Thankfully, in the source, there's a test mod that shows me what to do |
finishes the implementation Thank You TheWinABagel for the file I copied over to finish the job
|
Ok, one look at another source later and a quick grab to make things quicker and its done. ran it again and it now all works with the slot added and everything @williewillus |
|
Hm. It doesn't seem right that we have jsons in trinkets' namespace. Let me check the docs about how this is supposed to work. |
|
It should be the case; based on another mod I looked at with open source, it appears to be in the right spot |
|
It's important to mention that the "charm" slot does not exist in the Trinkets API by default, although the texture for it does. As such, the tooltip for any item that can be put in that slot will be missing a translation key; thus the following entry should be added to the lang file(s): For what it's worth, it seems that the most popular mod that implements a "charm" slot, Charm of Undying, defines the slot as |
|
That is true; this is more or less a fallback in case non-such are present; the code should work, and I have tested it in the space. |
|
I was told to make this to be applied for 1.20 and then retroactively for 1.19.2 |
Add hand/charm and moved
divaCharmandgoddessCharmto section (hopefuly I did this right)Creates a new charm slot in the mainland section
@williewillus NOTE: needs to be run like you said; I'm still fairly new to all of these things so I'm not sure how to go about running it.
I also want to give the trinket case the needed trinket compatibility since it is missing as Curios has it but it is outside of my ability to implement such
Hopefully this will generate the other files as needed