Fix missing handling of text components in 1.11.1>1.12 chat item rewriter

[LeonTG]

I never noticed that this was not handled by ViaVersion until upgrading to 1.20.3 and above

1.20.3 changed it so a client will be kicked if an invalid chat json text is sent to the client.

ViaVersion did not check for hover events using a JsonObject with a text element inside, and then made the hover event an empty array instead, which on 1.20.3 and above, would kick the client for the reason seen here:

I have tested this and it seems to have fixed the issue, now sending a item or entity hoverEvent on a 1.20.3+ client on a 1.8-1.11 server no longer kicks me

Hopefully I described the issue well and submitted an adequate fix for it! Let me know if anything is unclear or if there is changes you'd want me to do to the fix!

[FlorianMichael]

Didn't had the time to look at it in the last weeks, sorry about the delay!

While this seems to be valid, we should take a closer look at all ChatItemRewriter when properly migrating to MCStructs / adding all missing conversions.

Thanks!

[FlorianMichael]

Also could you please provide the nbt / command you used to fix/debug this? I might found some issues in the existing code as well

[LeonTG]

Also could you please provide the nbt / command you used to fix/debug this? I might found some issues in the existing code as well

The json that crashed me in the image above is:
{"extra":[{"bold":true,"color":"dark_red","text":"UHC"},{"color":"dark_gray","text":" » "},{"color":"gray","extra":[{"color":"white","hoverEvent":{"action":"show_item","value":[{"text":"{id:\"minecraft:diamond_sword\",Count:1b,Damage:0s}"}]},"extra":[{"translate":"item.swordDiamond.name"}],"text":"1x "},{"text":"\u0027 to \u0027"},{"color":"white","text":"MarcusWest"},{"text":"\u0027."}],"text":"Gave \u0027"}],"text":""}

When viewing a more clean version of that json, I've highlighted here the area that gets removed without my PR:

[FlorianMichael]

Are you able to reproduce this kick using /tellraw and your json? I can't reproduce this using latest ViaProxy, 1.20.4 client and 1.8 server, same for ViaVersion being installed on the spigot server.

[LeonTG]

Are you able to reproduce this kick using /tellraw and your json? I can't reproduce this using latest ViaProxy, 1.20.4 client and 1.8 server, same for ViaVersion being installed on the spigot server.

I believe /tellraw would change the formatting of the hover event back to a basic string primitive, which ViaVerison already handles

The way this json gets sent in my case is using the Spigot components API

[FlorianMichael]

Thanks for the PR, I decided to use MCStructs for the conversion to fix even more issues the current code has (For example you can split the nbt using translate and extra or you can insert multiple arrays into each other), see my PR: #3740