Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use ConfigParser to allow configuration of the server details #2485

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

egonw
Copy link
Collaborator

@egonw egonw commented Apr 23, 2024

Fixes #2429

Description

This patch (in progress) is rewriting Scholia to make various server-side details (e.g. SPARQL endpoint) configurable with a properties file.

Caveats

  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies: configparser, StringIO, os.path

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

The patch defaults use the WDQS and with the following scholia.cfg it will use the QLever Wikidata endpoint:

to be done

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@fnielsen
Copy link
Collaborator

I was planning on a dedicated module config with the Interface to the config file. Wouldn't that be more

@egonw
Copy link
Collaborator Author

egonw commented May 11, 2024

Virtuoso just updated their Wikidata SPARQL endpoint. @fnielsen, can you give me an update please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-level configurable
2 participants