Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if filter contains both bluetooth and usb members #196

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fail if filter contains both bluetooth and usb members #196

merged 1 commit into from
Sep 29, 2023

Conversation

beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Sep 20, 2023 •
edited

This PR makes sure requestPort() fails if filter contains both bluetooth and usb members. This matches Chromium implementation.

  if (filter->hasBluetoothServiceClassId()) {
    if (filter->hasUsbVendorId() || filter->hasUsbProductId()) {
      exception_state.ThrowTypeError(
          "A filter cannot specify both bluetoothServiceClassId and "
          "usbVendorId or usbProductId.");
      return nullptr;
    }

@nondebug @reillyeon Please review.

@beaufortfrancois beaufortfrancois merged commit 343fe09 into main Sep 29, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Sep 29, 2023
@beaufortfrancois @github-actions
Fail if filter contains both bluetooth and usb members (#196)
00e97ca 
SHA: 343fe09
Reason: push, by beaufortfrancois

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reillyeon reillyeon reillyeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beaufortfrancois @reillyeon