Specify connect/disconnect for Bluetooth serial ports #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
requested changes
Oct 13, 2023
reillyeon
approved these changes
Nov 17, 2023
| @@ -173,7 +173,7 @@ <h3> | |||
| <ol> | |||
| <li>Let |allPorts:list<SerialPort>| be an empty [=list=]. | |||
| </li> | |||
| <li>[=list/For each=] paired Bluetooth device: | |||
| <li>[=list/For each=] Bluetooth device registered with the system: | |||
There was a problem hiding this comment.
Was not using the "available" definition here intentional? This loop technically creates multiple "available Bluetooth serial ports" so saying "available Bluetooth device" is an abuse of the definition.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 19, 2023
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: TODO Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 19, 2023
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: TODO Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 20, 2023
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: TODO Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 20, 2023
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: TODO Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 21, 2023
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: TODO Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
github-actions bot
added a commit
that referenced
this pull request
Dec 21, 2023
SHA: 03b8824 Reason: push, by nondebug Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 22, 2023
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: TODO Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 4, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: TODO Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 9, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: TODO Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 1, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 1, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 4, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 5, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 6, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 6, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039155 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1268876}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 6, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039155 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1268876}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 14, 2024
…tooth serial ports, a=testonly Automatic update from web-platform-tests serial: Expose connection state for Bluetooth serial ports Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039155 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1268876} -- wpt-commits: 3e1658abd564779970097385353b23de9ad7b5c9 wpt-pr: 43240
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Mar 17, 2024
…tooth serial ports, a=testonly Automatic update from web-platform-tests serial: Expose connection state for Bluetooth serial ports Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039155 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1268876} -- wpt-commits: 3e1658abd564779970097385353b23de9ad7b5c9 wpt-pr: 43240
BruceDai
pushed a commit
to BruceDai/wpt
that referenced
this pull request
Mar 25, 2024
Relevant spec change: WICG/serial#197 This CL adds a connected attribute to the SerialPort interface that exposes the logical connection state of the serial port. The behavior for Bluetooth serial ports is changed so that the connect and disconnect events are dispatched when the connection state of the Bluetooth device changes. The behavior is unchanged for wired serial ports. Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/dkz0IdP7kao Bug: 1488031 Change-Id: I34b88246e62202c24eee08ad4a997aff7eadeebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5039155 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1268876}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.