Add notes about reasons an IG might not be included for bidding. #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattMenke2
reviewed
Feb 23, 2024
| * `owner`in the list of `interestGroupBuyers`. | ||
| * Non null `biddingLogicUrl`. | ||
| * At least one registered creative in the `ads` element. | ||
| * Priority, as stated by `priority` or calculated via `priorityVector`, is greater than or equal to 0. |
There was a problem hiding this comment.
Optional: Could add that fetches of biddingLogicUrl and biddingWasmHelperURL (if present) must succeed.
Fetch of trustedBiddingSignalsURL is allowed to fail or timeout, though perhaps we should change that.
dmdabbs
reviewed
Feb 23, 2024
| @@ -419,7 +419,13 @@ The values of some signals (those configured by fields `auctionSignals`, `seller | |||
|
|
|||
| #### 2.2 Auction Participants | |||
|
|
|||
| Each interest group the browser has joined and whose owner is in the list of `interestGroupBuyers` will have an opportunity to bid in the auction. See the "Buyers Provide Ads and Bidding Functions" section, below, for how interest groups bid. | |||
| Each interest group the browser has joined with: | |||
There was a problem hiding this comment.
Each non-negative targeted interest group, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.