Spec Multibid (reland) #1138
Spec Multibid (reland) #1138
Conversation
This permits generateBid() to return (and setBid to take) a sequence of bids as an alternative to a single one. A k-anon rerun, still limited to producing a single bid, will now happen when none of the returned bids are k-anonymous (which is equivalent to current behavior when one bid is produced). To make it easier to produce k-anonymous bids when component ads are involved without relying on a re-run, this also adds optional targetNumAdComponents and numMandatoryAdComponents fields to bid to request implementations to drop some component ads in order to make a bid k-anonymous. See WICG#595
|
Can you make a comment here linking to the old PR and pointing to each of the not-yet-resolved comments from the old reviews? |
|
How would I link to comments? |
|
On mobile right now so just posting this: https://stackoverflow.com/questions/25163598/how-do-i-reference-a-specific-issue-comment-on-github |
|
nm, found it. I think the only remaining comment is |
|
@domfarolino friendly ping. |
spec.bs
Outdated
| |oneOrManyBids|, an integer |multiBidLimit|, an [=interest group=] |ig|, a [=currency tag=] |expectedCurrency|, a [=boolean=] | ||
| |isComponentAuction| and a [=boolean=] |groupHasAdComponents|: | ||
| 1. Let |bidSequence| be [=sequence=]<{{GenerateBidOutput}}>. | ||
| 1. If |oneOrManyBids| is a {{GenerateBidOutput}}, then set |bidSequence| to « |oneOrManyBids| ». |
There was a problem hiding this comment.
I think you mean to take the type in as a union type, and get its "specific type"? (See my WebIDL link above)
There was a problem hiding this comment.
It's a bit more than that, it's basically a union of one GenerateBidOutput or a sequence of GenerateBidOutput, and I want to handle the singleton the same way I would handle a sequence with one entry
There was a problem hiding this comment.
Sure that makes sense, I'm recommending that you link to specific type instead of say "is a". See https://urlpattern.spec.whatwg.org/#ref-for-dfn-specific-type for example.
There was a problem hiding this comment.
Oh, didn't realize it was a term (the quotes somehow didn't clue me in). Done, thanks.
Co-authored-by: Dominic Farolino <domfarolino@gmail.com>
|
Is there any ordering indication on the sequence returned by generateBid? (e.g. the first ad in the sequence has the highest priority) Or is it just a set of ads that each has a equal weight? |
|
No semantic significance to order of sequence of bids [1], except the returned values are scored in order, which might matter for cumulative timeout, however. [1] order of component ads matters if you use targetNumAdComponents |
|
Ping Dominic? |
SHA: ebbee81 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This permits generateBid() to return (and setBid to take) a sequence of bids as an alternative to a single one. A k-anon rerun, still limited to producing a single bid, will now happen when none of the returned bids are k-anonymous (which is equivalent to current behavior when one bid is produced).
To make it easier to produce k-anonymous bids when component ads are involved without relying on a re-run, this also adds optional targetNumAdComponents and numMandatoryAdComponents fields to bid to request implementations to drop some component ads in order to make a bid k-anonymous.
See #595
Preview | Diff