Skip to content

Commit

Permalink
REGRESSION(276012@main): CMake fails with GObject-Introspection disabled
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=269377

Reviewed by Michael Catanzaro and Philippe Normand.

* Source/WebKit/PlatformGTK.cmake: Quote the expansion of ${GI_VERSION}
  to ensure VERSION_GREATER_EQUAL has at least an empty string as value
  to compare against; otherwise when the variable is undefined there was
  no left-hand side of the comparison, which resulted in CMake erroring
  due to wrong syntax.

Canonical link: https://commits.webkit.org/276019@main
  • Loading branch information
aperezdc committed Mar 13, 2024
1 parent 015bce0 commit 3a1c081
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/WebKit/PlatformGTK.cmake
Expand Up @@ -369,7 +369,7 @@ if (ENABLE_MEDIA_STREAM)
)
endif ()

if (${GI_VERSION} VERSION_GREATER_EQUAL 1.79.2)
if ("${GI_VERSION}" VERSION_GREATER_EQUAL 1.79.2)
set(USE_GI_FINISH_FUNC_ANNOTATION 1)
else ()
set(USE_GI_FINISH_FUNC_ANNOTATION 0)
Expand Down

0 comments on commit 3a1c081

Please sign in to comment.