Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself (Loïc Yhuel) to contributors.json #22389

Conversation

@hwti hwti requested a review from JonWBedard as a code owner January 4, 2024 18:35
@blino
Copy link
Contributor

blino commented Feb 8, 2024

@JonWBedard : hi, is it possible to merge this to allow @hwti to use the repo?
This is needed for example to add the request-merge-queue label to PRs.
Thanks!

@blino blino requested review from ryanhaddad and nt1m February 9, 2024 08:20
@blino blino requested a review from mcatanzaro March 7, 2024 12:42
@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2024
@hwti hwti force-pushed the eng/Add-myself-Loïc-Yhuel-to-contributors-json branch from c12e85a to 563e104 Compare March 7, 2024 15:08
@hwti
Copy link
Contributor Author

hwti commented Mar 7, 2024

GitHub secret detection prevented the merge-queue from pushing to the branch on my fork.
After synchronizing the main branch of the fork from the GitHub pages, I was able to push the rebased branch.

@hwti
Copy link
Contributor Author

hwti commented Mar 7, 2024

wincairo seems to have an issue with the branch name (but it didn't prevent the merge-queue from running on the first commit).
api-wpe failed on a test, which is obviously unrelated, is it why the merge queue didn't run on the rebased branch ?

@mcatanzaro
Copy link
Contributor

Merge queue will add the merge-blocking label if it fails. I assume it's just slow today.

@blino blino added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Mar 8, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-myself-Loïc-Yhuel-to-contributors-json branch from 563e104 to 123411a Compare March 8, 2024 09:53
@webkit-commit-queue
Copy link
Collaborator

Committed 275828@main (123411a): https://commits.webkit.org/275828@main

Reviewed commits have been landed. Closing PR #22389 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 8, 2024
@webkit-commit-queue webkit-commit-queue merged commit 123411a into WebKit:main Mar 8, 2024
@hwti hwti deleted the eng/Add-myself-Loïc-Yhuel-to-contributors-json branch March 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants