Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skia] Implement FontPlatformData::openTypeTable #25303

Merged
merged 1 commit into from Mar 2, 2024
Merged

[Skia] Implement FontPlatformData::openTypeTable #25303

merged 1 commit into from Mar 2, 2024

Conversation

TingPing
Copy link
Contributor

@TingPing TingPing commented Feb 29, 2024 •
edited by webkit-early-warning-system

38b6c34

[Skia] Implement FontPlatformData::openTypeTable
https://bugs.webkit.org/show_bug.cgi?id=270301

Reviewed by Carlos Garcia Campos.

Compared against freetype's implementation.

* Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp:
(WebCore::FontPlatformData::openTypeTable const):

Canonical link: https://commits.webkit.org/275578@main

a43eb47

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@TingPing TingPing self-assigned this Feb 29, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 7347f99)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ❌ 🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
❌ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
❌ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 gtk
❌ 🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
  🛠 tv ❌ 🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
  🛠 watch-sim

@TingPing TingPing added the WPE WebKit WebKit WPE component label Feb 29, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 49b1a63)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@TingPing TingPing added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 1, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash c2233b5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

donny-dont
donny-dont reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@donny-dont donny-dont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question before landing to potentially avoid all the conversions.

Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp Outdated Show resolved Hide resolved
@TingPing TingPing removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 1, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 1, 2024
@TingPing TingPing removed the merging-blocked Applied to prevent a change from being merged label Mar 1, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a43eb47)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@TingPing TingPing added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 1, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 1, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #13720.

@TingPing
[Skia] Implement FontPlatformData::openTypeTable
38b6c34 
https://bugs.webkit.org/show_bug.cgi?id=270301

Reviewed by Carlos Garcia Campos.

Compared against freetype's implementation.

* Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp:
(WebCore::FontPlatformData::openTypeTable const):

Canonical link: https://commits.webkit.org/275578@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275578@main (38b6c34): https://commits.webkit.org/275578@main

Reviewed commits have been landed. Closing PR #25303 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 38b6c34 into WebKit:main Mar 2, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donny-dont donny-dont donny-dont left review comments

@carlosgcampos carlosgcampos carlosgcampos approved these changes

Assignees

@TingPing TingPing

Labels
WPE WebKit WebKit WPE component
Projects
None yet
Milestone
No milestone
6 participants
@TingPing @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @donny-dont @carlosgcampos