Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Skia] Fix support for custom cursors #25372

Merged
merged 1 commit into from Mar 5, 2024
Merged

[Skia] Fix support for custom cursors #25372

merged 1 commit into from Mar 5, 2024

Conversation

TingPing
Copy link
Contributor

@TingPing TingPing commented Mar 2, 2024 •
edited by webkit-early-warning-system

1853a76

[Skia] Fix support for custom cursors
https://bugs.webkit.org/show_bug.cgi?id=270389

Reviewed by Carlos Garcia Campos.

* Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp:
(WebCore::ShareableBitmap::createImage):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
(WKWPE::View::setCursor):

Canonical link: https://commits.webkit.org/275665@main

9916b2e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@TingPing TingPing requested a review from zdobersek as a code owner March 2, 2024 02:05
@TingPing TingPing self-assigned this Mar 2, 2024
@TingPing TingPing requested a review from a team as a code owner March 2, 2024 02:05
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@TingPing TingPing added the WPE WebKit WebKit WPE component label Mar 2, 2024
@TingPing TingPing force-pushed the pgriffis/skia/customcursors branch from 05eaaa1 to ca01ead Compare March 2, 2024 12:25
@webkit-early-warning-system

This comment was marked as outdated.

Sign in to view
@TingPing TingPing force-pushed the pgriffis/skia/customcursors branch from ca01ead to 19bc2b3 Compare March 2, 2024 12:40
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 19bc2b3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

carlosgcampos
carlosgcampos approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@carlosgcampos carlosgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp Outdated Show resolved Hide resolved
Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp Outdated Show resolved Hide resolved
@TingPing TingPing force-pushed the pgriffis/skia/customcursors branch from 19bc2b3 to 9916b2e Compare March 4, 2024 15:03
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9916b2e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@TingPing TingPing added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 4, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Failed ios-wk2-wpt, api-ios, api-gtk checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #25372 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 4, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #13974.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 4, 2024
@TingPing TingPing added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Mar 5, 2024
@TingPing
[Skia] Fix support for custom cursors
1853a76 
https://bugs.webkit.org/show_bug.cgi?id=270389

Reviewed by Carlos Garcia Campos.

* Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp:
(WebCore::ShareableBitmap::createImage):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
(WKWPE::View::setCursor):

Canonical link: https://commits.webkit.org/275665@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275665@main (1853a76): https://commits.webkit.org/275665@main

Reviewed commits have been landed. Closing PR #25372 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1853a76 into WebKit:main Mar 5, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@zdobersek zdobersek Awaiting requested review from zdobersek zdobersek is a code owner

Assignees

@TingPing TingPing

Labels
WPE WebKit WebKit WPE component
Projects
None yet
Milestone
No milestone
5 participants
@TingPing @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @carlosgcampos