Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebCore] Add big endian bitmap texture #25424

Merged
merged 1 commit into from Mar 7, 2024
Merged

[WebCore] Add big endian bitmap texture #25424

merged 1 commit into from Mar 7, 2024

Conversation

sideeffect42
Copy link

@sideeffect42 sideeffect42 commented Mar 4, 2024 •
edited by webkit-early-warning-system

c37138c

[WebCore] Add big endian bitmap texture
https://bugs.webkit.org/show_bug.cgi?id=245446

Reviewed by Michael Catanzaro and Miguel Gomez.

Adding the ARGB bitmap for big endian fixes colours when WEBKIT_DISABLE_COMPOSITING_MODE=1 is set.

* Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp: add bitmap texture for big endian.

Canonical link: https://commits.webkit.org/275780@main

43c0443

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 4f104f7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ❌ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ❌ 🧪 api-gtk
  🛠 tv-sim
  🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 4, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 072f2a6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios ✅ 🧪 mac-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro requested a review from a team March 4, 2024 17:46
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 006aba0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash e3812ad)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk2 ⏳ 🧪 gtk-wk2
  🛠 tv   🧪 mac-AS-debug-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 watch
  🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 43c0443)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro mcatanzaro added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Mar 5, 2024
@mcatanzaro mcatanzaro removed the merge-queue Applied to send a pull request to merge-queue label Mar 5, 2024
@mcatanzaro mcatanzaro requested a review from a team March 5, 2024 16:31
@mcatanzaro
Copy link
Contributor

Hm, this should probably be reviewed by graphics reviewers

@magomez magomez added the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2024
@magomez
[WebCore] Add big endian bitmap texture
c37138c 
https://bugs.webkit.org/show_bug.cgi?id=245446

Reviewed by Michael Catanzaro and Miguel Gomez.

Adding the ARGB bitmap for big endian fixes colours when WEBKIT_DISABLE_COMPOSITING_MODE=1 is set.

* Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp: add bitmap texture for big endian.

Canonical link: https://commits.webkit.org/275780@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275780@main (c37138c): https://commits.webkit.org/275780@main

Reviewed commits have been landed. Closing PR #25424 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c37138c into WebKit:main Mar 7, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2024
@sideeffect42 sideeffect42 deleted the be-bitmap-texture branch March 8, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation left review comments

@mcatanzaro mcatanzaro mcatanzaro approved these changes

@magomez magomez magomez approved these changes

@alexgcastro alexgcastro Awaiting requested review from alexgcastro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@sideeffect42 @webkit-early-warning-system @mcatanzaro @webkit-commit-queue @Constellation @magomez @webkit-ews-buildbot