New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Skia] Add support for favicons on GTK #25735
[Skia] Add support for favicons on GTK #25735
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
d0ffdc7
to
b0b7635
Compare
This comment was marked as outdated.
This comment was marked as outdated.
LGTM |
b0b7635
to
26a1d0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
26a1d0c
to
98ebd8e
Compare
EWS run on previous version of this PR (hash 98ebd8e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks! I have only a few minor comments
98ebd8e
to
13daddb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
13daddb
to
6843b37
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6843b37
to
d6df65a
Compare
EWS run on previous version of this PR (hash d6df65a) |
d6df65a
to
bc9cc53
Compare
EWS run on current version of this PR (hash bc9cc53) |
https://bugs.webkit.org/show_bug.cgi?id=270811 Reviewed by Carlos Garcia Campos. * Source/WebCore/PlatformGTK.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp: Added. (WebCore::skiaImageToGdkTexture): * Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.h: Added. * Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp: (webkitFaviconDatabaseGetFaviconInternal): (webkit_favicon_database_get_favicon_finish): Canonical link: https://commits.webkit.org/275982@main
bc9cc53
to
e9c4929
Compare
Committed 275982@main (e9c4929): https://commits.webkit.org/275982@main Reviewed commits have been landed. Closing PR #25735 and removing active labels. |
e9c4929
bc9cc53
π§ͺ ios-wk2-wptπ§ͺ api-ios