Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Skia] Add support for favicons on GTK #25735

Merged
merged 1 commit into from Mar 12, 2024

Conversation

TingPing
Copy link
Contributor

@TingPing TingPing commented Mar 11, 2024

e9c4929

[Skia] Add support for favicons on GTK
https://bugs.webkit.org/show_bug.cgi?id=270811

Reviewed by Carlos Garcia Campos.

* Source/WebCore/PlatformGTK.cmake:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp: Added.
(WebCore::skiaImageToGdkTexture):
* Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.h: Added.
* Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseGetFaviconInternal):
(webkit_favicon_database_get_favicon_finish):

Canonical link: https://commits.webkit.org/275982@main

bc9cc53

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
  πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@TingPing TingPing requested a review from a team as a code owner March 11, 2024 18:52
@TingPing TingPing self-assigned this Mar 11, 2024
@TingPing TingPing added the WPE WebKit WebKit WPE component label Mar 11, 2024
@webkit-early-warning-system

This comment was marked as outdated.

@webkit-early-warning-system

This comment was marked as outdated.

@GeorgesStavracas
Copy link
Contributor

LGTM

@TingPing TingPing changed the title [Skia] Add support for favicons on GTK4 [Skia] Add support for favicons on GTK Mar 12, 2024
@webkit-early-warning-system

This comment was marked as outdated.

Copy link
Contributor

@carlosgcampos carlosgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks! I have only a few minor comments

Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp Outdated Show resolved Hide resolved
Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp Outdated Show resolved Hide resolved
Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp Outdated Show resolved Hide resolved
Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp Outdated Show resolved Hide resolved
Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp Outdated Show resolved Hide resolved
Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp Outdated Show resolved Hide resolved
Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp Outdated Show resolved Hide resolved
@webkit-early-warning-system

This comment was marked as outdated.

@webkit-early-warning-system

This comment was marked as outdated.

@TingPing TingPing added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 12, 2024
@carlosgcampos carlosgcampos removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Mar 12, 2024
@TingPing TingPing added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Mar 12, 2024
https://bugs.webkit.org/show_bug.cgi?id=270811

Reviewed by Carlos Garcia Campos.

* Source/WebCore/PlatformGTK.cmake:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp: Added.
(WebCore::skiaImageToGdkTexture):
* Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.h: Added.
* Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp:
(webkitFaviconDatabaseGetFaviconInternal):
(webkit_favicon_database_get_favicon_finish):

Canonical link: https://commits.webkit.org/275982@main
@webkit-commit-queue
Copy link
Collaborator

Committed 275982@main (e9c4929): https://commits.webkit.org/275982@main

Reviewed commits have been landed. Closing PR #25735 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e9c4929 into WebKit:main Mar 12, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WPE WebKit WebKit WPE component
Projects
None yet
5 participants