Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "= default" for constructors and destructors in more places #25925

Merged

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Mar 15, 2024

0cc86c2

Use "= default" for constructors and destructors in more places

https://bugs.webkit.org/show_bug.cgi?id=271031

Reviewed by Michael Catanzaro and Chris Dumez.

Similar to other patches, this extends our "= default" usage across
constructors and destructors in WebKit code.

* Source/WebCore/animation/AnimationEffect.cpp:
(AnimationEffect::AnimationEffect):
(AnimationEffect::~AnimationEffect):
* Source/WebCore/animation/KeyframeEffectStack.cpp:
(KeyframeEffectStack::KeyframeEffectStack):
(KeyframeEffectStack::~KeyframeEffectStack):
* Source/WebCore/animation/StyleOriginatedAnimation.cpp:
(StyleOriginatedAnimation::~StyleOriginatedAnimation):
* Source/WebCore/css/FontFaceSet.cpp:
(FontFaceSet::~FontFaceSet):
* Source/WebCore/html/HTMLPictureElement.cpp:
(HTMLPictureElement::~HTMLPictureElement):
* Source/WebCore/html/shadow/DataListButtonElement.cpp:
(DataListButtonElement::~DataListButtonElement):
* Source/WebCore/Modules/audiosession/NavigatorAudioSession.cpp:
(NavigatorAudioSession::NavigatorAudioSession):
(NavigatorAudioSession::~NavigatorAudioSession):
* Source/WebCore/Modules/fetch/FetchResponse.cpp:
(FetchResponse::Loader::~Loader):
* Source/WebCore/Modules/mediastream/RTCDataChannelRemoteHandler.cpp:
(RTCDataChannelRemoteHandler::~RTCDataChannelRemoteHandler):
* Source/WebCore/Modules/mediastream/RTCDataChannelRemoteSource.cpp:
(RTCDataChannelRemoteSource::~RTCDataChannelRemoteSource):
* Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:
(RTCRtpScriptTransformer::~RTCRtpScriptTransformer):
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:
(RTCRtpSFrameTransform::~RTCRtpSFrameTransform):
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp:
(RTCRtpSFrameTransformer::~RTCRtpSFrameTransformer):
* Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp:
(VideoTrackGenerator::~VideoTrackGenerator):
* Source/WebCore/Modules/notifications/NotificationEvent.cpp:
(NotificationEvent::~NotificationEvent):
* Source/WebCore/Modules/push-api/PushEvent.cpp:
(PushEvent::~PushEvent):
* Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp:
(RemotePlayback::~RemotePlayback):
* Source/WebCore/Modules/speech/SpeechRecognition.cpp:
(SpeechRecognition::~SpeechRecognition):
* Source/WebCore/Modules/streams/TransformStream.cpp:
(
TransformStream::~TransformStream):
* Source/WebCore/Modules/webauthn/cbor/CBORWriter.cpp:
(CBORWriter::~CBORWriter):
* Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp:
(WebCodecsAudioDecoder::~WebCodecsAudioDecoder):
* Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp:
(WebCodecsAudioEncoder::~WebCodecsAudioEncoder):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp:
(WebCodecsVideoDecoder::~WebCodecsVideoDecoder):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCodecsVideoEncoder::~WebCodecsVideoEncoder):
* Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:
(CryptoDigest::CryptoDigest):
(CryptoDigest::~CryptoDigest():
* Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb:
(Settings::~Settings):
* Source/WTF/wtf/AutomaticThread.cpp:
(AutomaticThreadCondition::AutomaticThreadCondition):
(AutomaticThreadCondition::~AutomaticThreadCondition):
* Source/WTF/wtf/ConcurrentPtrHashSet.cpp:
(ConcurrentPtrHashSet::~ConcurrentPtrHashSet):
* Source/WTF/wtf/FunctionDispatcher.cpp:
(FunctionDispatcher::FunctionDispatcher):
(FunctionDispatcher::~FunctionDispatcher):
* Source/WTF/wtf/glib/SocketConnection.cpp:
(SocketConnection::~SocketConnection):
* Source/WTF/wtf/LockedPrintStream.cpp:
(LockedPrintStream::~LockedPrintStream):
* Source/WTF/wtf/persistence/PersistentDecoder.cpp:
(Decoder::~Decoder):
* Source/WTF/wtf/persistence/PersistentEncoder.cpp:
(Encoder::Encoder):
(Encoder::~Encoder):
* Source/WTF/wtf/posix/ThreadingPOSIX.cpp:
(Thread::~Thread):
* Source/WTF/wtf/PrintStream.cpp:
(PrintStream::PrintStream):
(PrintStream::~PrintStream):
* Source/WTF/wtf/RefCountedLeakCounter.cpp:
(RefCountedLeakCounter::~RefCountedLeakCounter):
* Source/WTF/wtf/text/StringView.cpp:
(StringView::GraphemeClusters::Iterator::~Iterator):
* Source/WTF/wtf/win/ThreadingWin.cpp:
(Mutex::~Mutex):
(ThreadCondition::~ThreadCondition):

Canonical link: https://commits.webkit.org/276159@main

d7f94f5

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ›  jsc-armv7
βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-armv7-tests

@Ahmad-S792 Ahmad-S792 added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 15, 2024
@Ahmad-S792 Ahmad-S792 self-assigned this Mar 15, 2024
@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review March 15, 2024 10:52
@Ahmad-S792 Ahmad-S792 requested review from a team, graouts, cdumez and rniwa as code owners March 15, 2024 10:52
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Mar 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=271031

Reviewed by Michael Catanzaro and Chris Dumez.

Similar to other patches, this extends our "= default" usage across
constructors and destructors in WebKit code.

* Source/WebCore/animation/AnimationEffect.cpp:
(AnimationEffect::AnimationEffect):
(AnimationEffect::~AnimationEffect):
* Source/WebCore/animation/KeyframeEffectStack.cpp:
(KeyframeEffectStack::KeyframeEffectStack):
(KeyframeEffectStack::~KeyframeEffectStack):
* Source/WebCore/animation/StyleOriginatedAnimation.cpp:
(StyleOriginatedAnimation::~StyleOriginatedAnimation):
* Source/WebCore/css/FontFaceSet.cpp:
(FontFaceSet::~FontFaceSet):
* Source/WebCore/html/HTMLPictureElement.cpp:
(HTMLPictureElement::~HTMLPictureElement):
* Source/WebCore/html/shadow/DataListButtonElement.cpp:
(DataListButtonElement::~DataListButtonElement):
* Source/WebCore/Modules/audiosession/NavigatorAudioSession.cpp:
(NavigatorAudioSession::NavigatorAudioSession):
(NavigatorAudioSession::~NavigatorAudioSession):
* Source/WebCore/Modules/fetch/FetchResponse.cpp:
(FetchResponse::Loader::~Loader):
* Source/WebCore/Modules/mediastream/RTCDataChannelRemoteHandler.cpp:
(RTCDataChannelRemoteHandler::~RTCDataChannelRemoteHandler):
* Source/WebCore/Modules/mediastream/RTCDataChannelRemoteSource.cpp:
(RTCDataChannelRemoteSource::~RTCDataChannelRemoteSource):
* Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp:
(RTCRtpScriptTransformer::~RTCRtpScriptTransformer):
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:
(RTCRtpSFrameTransform::~RTCRtpSFrameTransform):
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp:
(RTCRtpSFrameTransformer::~RTCRtpSFrameTransformer):
* Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp:
(VideoTrackGenerator::~VideoTrackGenerator):
* Source/WebCore/Modules/notifications/NotificationEvent.cpp:
(NotificationEvent::~NotificationEvent):
* Source/WebCore/Modules/push-api/PushEvent.cpp:
(PushEvent::~PushEvent):
* Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp:
(RemotePlayback::~RemotePlayback):
* Source/WebCore/Modules/speech/SpeechRecognition.cpp:
(SpeechRecognition::~SpeechRecognition):
* Source/WebCore/Modules/streams/TransformStream.cpp:
(
TransformStream::~TransformStream):
* Source/WebCore/Modules/webauthn/cbor/CBORWriter.cpp:
(CBORWriter::~CBORWriter):
* Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp:
(WebCodecsAudioDecoder::~WebCodecsAudioDecoder):
* Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp:
(WebCodecsAudioEncoder::~WebCodecsAudioEncoder):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp:
(WebCodecsVideoDecoder::~WebCodecsVideoDecoder):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp:
(WebCodecsVideoEncoder::~WebCodecsVideoEncoder):
* Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:
(CryptoDigest::CryptoDigest):
(CryptoDigest::~CryptoDigest():
* Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb:
(Settings::~Settings):
* Source/WTF/wtf/AutomaticThread.cpp:
(AutomaticThreadCondition::AutomaticThreadCondition):
(AutomaticThreadCondition::~AutomaticThreadCondition):
* Source/WTF/wtf/ConcurrentPtrHashSet.cpp:
(ConcurrentPtrHashSet::~ConcurrentPtrHashSet):
* Source/WTF/wtf/FunctionDispatcher.cpp:
(FunctionDispatcher::FunctionDispatcher):
(FunctionDispatcher::~FunctionDispatcher):
* Source/WTF/wtf/glib/SocketConnection.cpp:
(SocketConnection::~SocketConnection):
* Source/WTF/wtf/LockedPrintStream.cpp:
(LockedPrintStream::~LockedPrintStream):
* Source/WTF/wtf/persistence/PersistentDecoder.cpp:
(Decoder::~Decoder):
* Source/WTF/wtf/persistence/PersistentEncoder.cpp:
(Encoder::Encoder):
(Encoder::~Encoder):
* Source/WTF/wtf/posix/ThreadingPOSIX.cpp:
(Thread::~Thread):
* Source/WTF/wtf/PrintStream.cpp:
(PrintStream::PrintStream):
(PrintStream::~PrintStream):
* Source/WTF/wtf/RefCountedLeakCounter.cpp:
(RefCountedLeakCounter::~RefCountedLeakCounter):
* Source/WTF/wtf/text/StringView.cpp:
(StringView::GraphemeClusters::Iterator::~Iterator):
* Source/WTF/wtf/win/ThreadingWin.cpp:
(Mutex::~Mutex):
(ThreadCondition::~ThreadCondition):

Canonical link: https://commits.webkit.org/276159@main
@webkit-commit-queue
Copy link
Collaborator

Committed 276159@main (0cc86c2): https://commits.webkit.org/276159@main

Reviewed commits have been landed. Closing PR #25925 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0cc86c2 into WebKit:main Mar 15, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 15, 2024
@Ahmad-S792 Ahmad-S792 deleted the use-more-default-across-WebKit branch March 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
5 participants