New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "= default" for constructors and destructors in more places #25925
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Ahmad-S792:use-more-default-across-WebKit
Mar 15, 2024
Merged
Use "= default" for constructors and destructors in more places #25925
webkit-commit-queue
merged 1 commit into
WebKit:main
from
Ahmad-S792:use-more-default-across-WebKit
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahmad-S792
added
the
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
label
Mar 15, 2024
EWS run on current version of this PR (hash d7f94f5) |
Ahmad-S792
requested review from
a team,
graouts,
cdumez and
rniwa
as code owners
March 15, 2024 10:52
mcatanzaro
approved these changes
Mar 15, 2024
cdumez
approved these changes
Mar 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=271031 Reviewed by Michael Catanzaro and Chris Dumez. Similar to other patches, this extends our "= default" usage across constructors and destructors in WebKit code. * Source/WebCore/animation/AnimationEffect.cpp: (AnimationEffect::AnimationEffect): (AnimationEffect::~AnimationEffect): * Source/WebCore/animation/KeyframeEffectStack.cpp: (KeyframeEffectStack::KeyframeEffectStack): (KeyframeEffectStack::~KeyframeEffectStack): * Source/WebCore/animation/StyleOriginatedAnimation.cpp: (StyleOriginatedAnimation::~StyleOriginatedAnimation): * Source/WebCore/css/FontFaceSet.cpp: (FontFaceSet::~FontFaceSet): * Source/WebCore/html/HTMLPictureElement.cpp: (HTMLPictureElement::~HTMLPictureElement): * Source/WebCore/html/shadow/DataListButtonElement.cpp: (DataListButtonElement::~DataListButtonElement): * Source/WebCore/Modules/audiosession/NavigatorAudioSession.cpp: (NavigatorAudioSession::NavigatorAudioSession): (NavigatorAudioSession::~NavigatorAudioSession): * Source/WebCore/Modules/fetch/FetchResponse.cpp: (FetchResponse::Loader::~Loader): * Source/WebCore/Modules/mediastream/RTCDataChannelRemoteHandler.cpp: (RTCDataChannelRemoteHandler::~RTCDataChannelRemoteHandler): * Source/WebCore/Modules/mediastream/RTCDataChannelRemoteSource.cpp: (RTCDataChannelRemoteSource::~RTCDataChannelRemoteSource): * Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp: (RTCRtpScriptTransformer::~RTCRtpScriptTransformer): * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp: (RTCRtpSFrameTransform::~RTCRtpSFrameTransform): * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformer.cpp: (RTCRtpSFrameTransformer::~RTCRtpSFrameTransformer): * Source/WebCore/Modules/mediastream/VideoTrackGenerator.cpp: (VideoTrackGenerator::~VideoTrackGenerator): * Source/WebCore/Modules/notifications/NotificationEvent.cpp: (NotificationEvent::~NotificationEvent): * Source/WebCore/Modules/push-api/PushEvent.cpp: (PushEvent::~PushEvent): * Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp: (RemotePlayback::~RemotePlayback): * Source/WebCore/Modules/speech/SpeechRecognition.cpp: (SpeechRecognition::~SpeechRecognition): * Source/WebCore/Modules/streams/TransformStream.cpp: ( TransformStream::~TransformStream): * Source/WebCore/Modules/webauthn/cbor/CBORWriter.cpp: (CBORWriter::~CBORWriter): * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCodecsAudioDecoder::~WebCodecsAudioDecoder): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCodecsAudioEncoder::~WebCodecsAudioEncoder): * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp: (WebCodecsVideoDecoder::~WebCodecsVideoDecoder): * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp: (WebCodecsVideoEncoder::~WebCodecsVideoEncoder): * Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp: (CryptoDigest::CryptoDigest): (CryptoDigest::~CryptoDigest(): * Source/WebCore/Scripts/SettingsTemplates/Settings.cpp.erb: (Settings::~Settings): * Source/WTF/wtf/AutomaticThread.cpp: (AutomaticThreadCondition::AutomaticThreadCondition): (AutomaticThreadCondition::~AutomaticThreadCondition): * Source/WTF/wtf/ConcurrentPtrHashSet.cpp: (ConcurrentPtrHashSet::~ConcurrentPtrHashSet): * Source/WTF/wtf/FunctionDispatcher.cpp: (FunctionDispatcher::FunctionDispatcher): (FunctionDispatcher::~FunctionDispatcher): * Source/WTF/wtf/glib/SocketConnection.cpp: (SocketConnection::~SocketConnection): * Source/WTF/wtf/LockedPrintStream.cpp: (LockedPrintStream::~LockedPrintStream): * Source/WTF/wtf/persistence/PersistentDecoder.cpp: (Decoder::~Decoder): * Source/WTF/wtf/persistence/PersistentEncoder.cpp: (Encoder::Encoder): (Encoder::~Encoder): * Source/WTF/wtf/posix/ThreadingPOSIX.cpp: (Thread::~Thread): * Source/WTF/wtf/PrintStream.cpp: (PrintStream::PrintStream): (PrintStream::~PrintStream): * Source/WTF/wtf/RefCountedLeakCounter.cpp: (RefCountedLeakCounter::~RefCountedLeakCounter): * Source/WTF/wtf/text/StringView.cpp: (StringView::GraphemeClusters::Iterator::~Iterator): * Source/WTF/wtf/win/ThreadingWin.cpp: (Mutex::~Mutex): (ThreadCondition::~ThreadCondition): Canonical link: https://commits.webkit.org/276159@main
webkit-commit-queue
force-pushed
the
use-more-default-across-WebKit
branch
from
March 15, 2024 15:21
d7f94f5
to
0cc86c2
Compare
Committed 276159@main (0cc86c2): https://commits.webkit.org/276159@main Reviewed commits have been landed. Closing PR #25925 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0cc86c2
d7f94f5