Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK] Failed to create GBM buffer of size 0x0: Invalid argument #26043

Merged
merged 1 commit into from Mar 19, 2024

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Mar 18, 2024

c3a0173

[GTK] Failed to create GBM buffer of size 0x0: Invalid argument
https://bugs.webkit.org/show_bug.cgi?id=265154

Reviewed by Michael Catanzaro.

This happens because in some cases we schedule a layer flush before the
drawing area size is initially updated. It's easier to happen in the
case of inspector because we don't delay the web process creation until
the first load in that case. We should just ignore layer flush requests
when the view size is empty since we won't be able to render anything
anyway. Also set the device scale factor before the page is initialized
to avoid sending an IPC message right after web page creation.

* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::scheduleLayerFlush):

Canonical link: https://commits.webkit.org/276337@main

79773f4

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ›  wpe-skia
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 ❌ πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@carlosgcampos carlosgcampos self-assigned this Mar 18, 2024
@carlosgcampos carlosgcampos added the WebKitGTK Bugs related to the Gtk API layer. label Mar 18, 2024
Copy link
Contributor

@mcatanzaro mcatanzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Carlos!

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 18, 2024
@carlosgcampos carlosgcampos added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Mar 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=265154

Reviewed by Michael Catanzaro.

This happens because in some cases we schedule a layer flush before the
drawing area size is initially updated. It's easier to happen in the
case of inspector because we don't delay the web process creation until
the first load in that case. We should just ignore layer flush requests
when the view size is empty since we won't be able to render anything
anyway. Also set the device scale factor before the page is initialized
to avoid sending an IPC message right after web page creation.

* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::scheduleLayerFlush):

Canonical link: https://commits.webkit.org/276337@main
@webkit-commit-queue
Copy link
Collaborator

Committed 276337@main (c3a0173): https://commits.webkit.org/276337@main

Reviewed commits have been landed. Closing PR #26043 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c3a0173 into WebKit:main Mar 19, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 19, 2024
@carlosgcampos carlosgcampos deleted the gtk-gdb-crash branch March 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
5 participants