Remove non-standard width() and height() functions of HTMLDocument

[Ahmad-S792]

9e4d690

Remove non-standard `width()` and `height()` functions of HTMLDocument

https://bugs.webkit.org/show_bug.cgi?id=271190

Reviewed by Ryosuke Niwa and Michael Catanzaro.

This patch is to remove remaining code for dropped `HTMLDocument.width / height`
attributes, which were dropped in 171244@main (via IDL changes) and later
removed in 179619@main (both in 2016 - via removal from IDL).

* Source/WebCore/html/HTMLDocument.cpp:
(HTMLDocument::width): Deleted
(HTMLDocument::height): Deleted
* Source/WebCore/html/HTMLDocument.h:
* Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm:
(width):
(height):
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLDocument.cpp:
(webkit_dom_html_document_get_width):
(webkit_dom_html_document_get_height):

Canonical link: https://commits.webkit.org/276488@main

450f296

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash bc9b1fc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
⏳ 🛠 🧪 jsc	🧪 api-ios	🧪 mac-wk2	❌ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64	🛠 tv	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	🛠 tv-sim		❌ 🧪 api-gtk
	🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 2a7c420)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	🛠 mac	🛠 wpe	🛠 wincairo
✅ 🧪 bindings	🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	🛠 wpe-skia
⏳ 🛠 🧪 jsc	🧪 api-ios	🧪 mac-wk2	❌ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64	🛠 tv	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	🛠 tv-sim	🧪 mac-wk2-stress	❌ 🧪 api-gtk
	🛠 watch
	🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 5cb57af)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

[annevk]

I would remove " (from WebKit and WebKitLegacy)" as it's inaccurate. These are still exposed in WebKitLegacy.

[annevk]

Thanks! This looks good to me, but I'd prefer @rniwa / @cdumez to sign off and someone from the Linux ports for the API changes.

[webkit-early-warning-system]

EWS run on previous version of this PR (hash f35e335)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
🧪 bindings	⏳ 🛠 ios-sim	🛠 mac-AS-debug	✅ 🧪 wpe-wk2
🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
⏳ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	⏳ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch
	⏳ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 450f296)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[aperezdc]

The DOM API has been deprecated since WebKitGTK version 2.22.0 (September 2018, four and a half years ago), and has never been part of WPE. Building WebKitGTK against GTK4 disables the whole DOM API. At this point we would expect everybody to have moved on; we only keep the library and its symbols around to prevent old applications that haven't been updated from segfaulting at load time.

I think this change is okay for the GTK port, if @carlosgcampos agrees let's merge it.

[mcatanzaro]

If Apple is OK with the API changes in DOMHTMLDocument.mm, then this is good.

[carlosgcampos]

LGTM

[webkit-commit-queue]

Committed 276488@main (9e4d690): https://commits.webkit.org/276488@main

Reviewed commits have been landed. Closing PR #26082 and removing active labels.