Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPE] Introduce USE(ATK) #26110

Merged
merged 1 commit into from Mar 20, 2024
Merged

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Mar 19, 2024

9d2e186

[WPE] Introduce USE(ATK)
https://bugs.webkit.org/show_bug.cgi?id=267508

Reviewed by Michael Catanzaro.

ENABLE_ACCESSIBILITY was removed in 273021@main, so add USE_ATK to keep
accessibility optional in the WPE port.

* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h:
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.h:
* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
(WKWPE::m_backend):
(WKWPE::View::~View):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.h:
* Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Tools/MiniBrowser/wpe/CMakeLists.txt:
* Tools/MiniBrowser/wpe/main.cpp:
(activate):
* Tools/wpe/backends/PlatformWPE.cmake:
* Tools/wpe/backends/ViewBackend.cpp:
(WPEToolingBackends::ViewBackend::initializeAccessibility):
(WPEToolingBackends::ViewBackend::updateAccessibilityState):
* Tools/wpe/backends/atk/ViewBackendAtk.cpp:
* Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp:
* Tools/wpe/backends/atk/WebKitAccessibleApplication.h:

Canonical link: https://commits.webkit.org/276392@main

9f0c406

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 loading πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
loading πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
βœ… πŸ›  πŸ§ͺ jsc loading-orange πŸ§ͺ api-ios loading πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
⏳ πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv loading-orange πŸ§ͺ mac-AS-debug-wk2 loading πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
⏳ πŸ›  watch βœ… πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-armv7-tests

@carlosgcampos carlosgcampos requested review from zdobersek and a team as code owners March 19, 2024 09:41
@carlosgcampos carlosgcampos self-assigned this Mar 19, 2024
@carlosgcampos carlosgcampos added the WPE WebKit WebKit WPE component label Mar 19, 2024
@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 20, 2024
https://bugs.webkit.org/show_bug.cgi?id=267508

Reviewed by Michael Catanzaro.

ENABLE_ACCESSIBILITY was removed in 273021@main, so add USE_ATK to keep
accessibility optional in the WPE port.

* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h:
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp:
* Source/WebKit/UIProcess/API/wpe/PageClientImpl.h:
* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
(WKWPE::m_backend):
(WKWPE::View::~View):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.h:
* Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Tools/MiniBrowser/wpe/CMakeLists.txt:
* Tools/MiniBrowser/wpe/main.cpp:
(activate):
* Tools/wpe/backends/PlatformWPE.cmake:
* Tools/wpe/backends/ViewBackend.cpp:
(WPEToolingBackends::ViewBackend::initializeAccessibility):
(WPEToolingBackends::ViewBackend::updateAccessibilityState):
* Tools/wpe/backends/atk/ViewBackendAtk.cpp:
* Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp:
* Tools/wpe/backends/atk/WebKitAccessibleApplication.h:

Canonical link: https://commits.webkit.org/276392@main
@webkit-commit-queue
Copy link
Collaborator

Committed 276392@main (9d2e186): https://commits.webkit.org/276392@main

Reviewed commits have been landed. Closing PR #26110 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9d2e186 into WebKit:main Mar 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 20, 2024
@carlosgcampos carlosgcampos deleted the wpe-atk branch March 20, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WPE WebKit WebKit WPE component
Projects
None yet
4 participants