Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPE][CMake] Cannot complete distcheck with ENABLE_WPE_1_1_API=OFF #26265

Merged
merged 1 commit into from Mar 21, 2024

Conversation

aperezdc
Copy link
Contributor

@aperezdc aperezdc commented Mar 21, 2024

fc03e5d

[WPE][CMake] Cannot complete distcheck with ENABLE_WPE_1_1_API=OFF
https://bugs.webkit.org/show_bug.cgi?id=265440

Reviewed by Michael Catanzaro.

Change which directory with documentation for the WebProcess extension
API gets packaged when creating release tarballs.

* Source/cmake/OptionsWPE.cmake: Add a new variable for name of the
  pkg-config module of the WebProcess extension API, reuse it to define
  the paths of the .pc files.
* Tools/wpe/manifest.txt.in: Change the generated WebProcess extension
  API output directory path to use the new variable.

Canonical link: https://commits.webkit.org/276496@main

55b8749

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ§ͺ api-wpe
  πŸ§ͺ ios-wk2-wpt   πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
  πŸ›  πŸ§ͺ jsc   πŸ§ͺ api-ios   πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
  πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2   πŸ§ͺ gtk-wk2
  πŸ›  tv-sim   πŸ§ͺ api-gtk
  πŸ›  watch βœ… πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-armv7-tests

@aperezdc aperezdc requested review from zdobersek and a team as code owners March 21, 2024 21:21
@aperezdc aperezdc self-assigned this Mar 21, 2024
@aperezdc aperezdc added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Mar 21, 2024
@aperezdc aperezdc changed the title Cannot complete distcheck with ENABLE_WPE_1_1_API=OFF https://bugs.webkit.org/show_bug.cgi?id=265440 [WPE][CMake] Cannot complete distcheck with ENABLE_WPE_1_1_API=OFF Mar 21, 2024
@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 21, 2024
https://bugs.webkit.org/show_bug.cgi?id=265440

Reviewed by Michael Catanzaro.

Change which directory with documentation for the WebProcess extension
API gets packaged when creating release tarballs.

* Source/cmake/OptionsWPE.cmake: Add a new variable for name of the
  pkg-config module of the WebProcess extension API, reuse it to define
  the paths of the .pc files.
* Tools/wpe/manifest.txt.in: Change the generated WebProcess extension
  API output directory path to use the new variable.

Canonical link: https://commits.webkit.org/276496@main
@webkit-commit-queue
Copy link
Collaborator

Committed 276496@main (fc03e5d): https://commits.webkit.org/276496@main

Reviewed commits have been landed. Closing PR #26265 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fc03e5d into WebKit:main Mar 21, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants