[GLib] Script rewrite-compile-commands missing from release tarballs #26407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
added
the
Tools / Tests
|
EWS run on current version of this PR (hash f4156a8)
|
mcatanzaro
approved these changes
Mar 25, 2024
|
Thanks for adding the Tools/Scripts/rewrite-compile-commands to the sources tarball. This fix builds with -DCMAKE_EXPORT_COMPILE_COMMANDS=ON like Yocto cmake.class does in the latest release. |
aperezdc
added
the
unsafe-merge-queue
You're welcome. I will be backporting the patch to the 2.44 branch as well. |
https://bugs.webkit.org/show_bug.cgi?id=271644 Reviewed by Michael Catanzaro. * Tools/gtk/manifest.txt.in: List Tools/Scripts/rewrite-compile-commands for inclusion in release tarballs. * Tools/wpe/manifest.txt.in: Ditto. Canonical link: https://commits.webkit.org/276622@main
webkit-commit-queue
force-pushed
the
dist-rewrite-commands
branch
from
f4156a8
to
aaef68e
Compare
|
Committed 276622@main (aaef68e): https://commits.webkit.org/276622@main Reviewed commits have been landed. Closing PR #26407 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aaef68e
f4156a8
🛠 ios🛠 mac🛠 wpe🛠 wincairo🧪 bindings🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-skia🧪 api-ios🧪 mac-wk2🛠 gtk🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 mac-wk2-stress🧪 api-gtk🛠 watch🛠 watch-sim