[DropbearServerPlugin] Initial version for review #121
Conversation
…red library & executable
… of Dropbear plugin
s-rapolu
changed the title
…de review feedback
|
| @@ -0,0 +1,76 @@ | |||
| --- a/Makefile.in 2016-07-21 20:47:09.000000000 +0530 | |||
There was a problem hiding this comment.
Patch needs appropriate format-patch header, including commit log providing a reason for the patch. For more info see: https://git-scm.com/docs/git-format-patch
There was a problem hiding this comment.
Yes, made the corrections and now created the patch with git format-patch header.
| @@ -0,0 +1,398 @@ | |||
| --- a/svr-main.c 2016-07-21 20:47:09.000000000 +0530 | |||
There was a problem hiding this comment.
Patch needs appropriate format-patch header, including commit log providing a reason for the patch. For more info see: https://git-scm.com/docs/git-format-patch
There was a problem hiding this comment.
Yes, made the corrections and now created the patch with git format-patch header.
| @@ -0,0 +1,12 @@ | |||
| --- a/configure.ac 2016-07-21 20:47:09.000000000 +0530 | |||
There was a problem hiding this comment.
Patch needs appropriate format-patch header, including commit log providing a reason for the patch. For more info see: https://git-scm.com/docs/git-format-patch
There was a problem hiding this comment.
Yes, made the corrections and now created the patch with git format-patch header.
| @@ -0,0 +1,31 @@ | |||
| --- a/libdropbear.h 2019-08-28 20:32:09.684490106 +0530 | |||
There was a problem hiding this comment.
Patch needs appropriate format-patch header, including commit log providing a reason for the patch. For more info see: https://git-scm.com/docs/git-format-patch
There was a problem hiding this comment.
Yes, made the corrections and now created the patch with git format-patch header.
| @@ -0,0 +1,14 @@ | |||
| --- a/libdropbear.pc.in 1970-01-01 05:30:00.000000000 +0530 | |||
There was a problem hiding this comment.
Patch needs appropriate format-patch header, including commit log providing a reason for the patch. For more info see: https://git-scm.com/docs/git-format-patch
There was a problem hiding this comment.
Yes, made the corrections and now created the patch with git format-patch header.
| @@ -0,0 +1,172 @@ | |||
| --- a/linkedlist.h 2019-07-11 14:07:04.040000000 +0530 | |||
There was a problem hiding this comment.
Patch needs appropriate format-patch header, including commit log providing a reason for the patch. For more info see: https://git-scm.com/docs/git-format-patch
There was a problem hiding this comment.
Yes, made the corrections and now created the patch with git format-patch header.
| @@ -603,6 +603,13 @@ config BR2_PACKAGE_WPEFRAMEWORK_SYSTEMCOMMANDS | |||
| help | |||
| SystemCommands Plugin | |||
|
|
|||
| config BR2_PACKAGE_WPEFRAMEWORK_SECURESHELLSERVER | |||
| select BR2_PACKAGE_WPEFRAMEWORK_PLUGINS | |||
There was a problem hiding this comment.
I dont think this is needed, you're already in the wpeframework-plugins config right?
| WPEFRAMEWORK_PLUGINS_VERSION = 8b70bd116e65f8824f060e0e26a4b1cfe65e27cd | ||
| WPEFRAMEWORK_PLUGINS_SITE = $(call github,WebPlatformForEmbedded,WPEFrameworkPlugins,$(WPEFRAMEWORK_PLUGINS_VERSION)) | ||
| WPEFRAMEWORK_PLUGINS_VERSION = 5d0769cea06138762ac8ecc102b5b8e5c9b3a863 | ||
| WPEFRAMEWORK_PLUGINS_SITE = $(call github,s-rapolu,WPEFrameworkPlugins,$(WPEFRAMEWORK_PLUGINS_VERSION)) |
There was a problem hiding this comment.
We cant point to your fork, this needs to be a commit on the main repository (master) that has the required changes to support the ssh server plugin.
There was a problem hiding this comment.
Sorry, corrected the mistake and now pointing it to master.
| @@ -72,6 +72,17 @@ ifeq ($(BR2_PACKAGE_WPEFRAMEWORK_DICTIONARY),y) | |||
| WPEFRAMEWORK_PLUGINS_CONF_OPTS += -DPLUGIN_DICTIONARY=ON | |||
| endif | |||
|
|
|||
| ifeq ($(BR2_PACKAGE_WPEFRAMEWORK_SECURESHELLSERVER),y) | |||
There was a problem hiding this comment.
Can you move this down to other S related selections? Trying to organize this A-Z for readability.
| WPEFRAMEWORK_VERSION = aed13867c93fe76dc29d32abe4237559cc19b62c | ||
| WPEFRAMEWORK_SITE = $(call github,WebPlatformForEmbedded,WPEFramework,$(WPEFRAMEWORK_VERSION)) | ||
| WPEFRAMEWORK_VERSION = 2c1a62d177473c67c1abbd41147a051edb436433 | ||
| WPEFRAMEWORK_SITE = $(call github,s-rapolu,WPEFramework,$(WPEFRAMEWORK_VERSION)) |
There was a problem hiding this comment.
Same here, cant point the entire buildroot to your fork. Needs to point to master with your changes merged in on the main repo.
There was a problem hiding this comment.
Sorry, corrected the mistake and now pointing it to master.
Signed-off-by: Suman Rapolu <suman.rapolu@soctronics.com>
… and wpeframework-plugins.mk to refer main repositories instead of a forked repository
Please review it and let us know your feedback. |
Dropbear plugin implementation related changes in buildroot repository.