Prevent race condition in loadSource by writing to a temporary file

Wedge · Feb 6, 2017 · de8a0d3 · de8a0d3
1 parent 9bc6cba
commit de8a0d3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/core/app/Subs-CachePHP.php b/core/app/Subs-CachePHP.php
@@ -15,8 +15,10 @@
 // Build the cached version of our source file
 function cache_source_file($source, $dest)
 {
-	apply_plugin_mods($source, $dest);
-	minify_php($dest);
+	$dest_locked = substr($dest, 0, -4).'-'.mt_rand(10000, 99999).'.php';
+	apply_plugin_mods($source, $dest_locked);
+	minify_php($dest_locked);
+	rename($dest_locked, $dest);
 }
 
 // Cache a minified PHP file.